Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update rust crate thiserror to v2 - abandoned #303

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 10, 2024

This PR contains the following updates:

Package Type Update Change
thiserror dependencies major 1 -> 2

Release Notes

dtolnay/thiserror (thiserror)

v2.0.3

Compare Source

  • Support the same Path field being repeated in both Debug and Display representation in error message (#​383)
  • Improve error message when a format trait used in error message is not implemented by some field (#​384)

v2.0.2

Compare Source

  • Fix hang on invalid input inside #[error(...)] attribute (#​382)

v2.0.1

Compare Source

  • Support errors that contain a dynamically sized final field (#​375)
  • Improve inference of trait bounds for fields that are interpolated multiple times in an error message (#​377)

v2.0.0

Compare Source

Breaking changes

  • Referencing keyword-named fields by a raw identifier like {r#type} inside a format string is no longer accepted; simply use the unraw name like {type} (#​347)

    This aligns thiserror with the standard library's formatting macros, which gained support for implicit argument capture later than the release of this feature in thiserror 1.x.

    #[derive(Error, Debug)]
    #[error("... {type} ...")]  // Before: {r#type}
    pub struct Error {
        pub r#type: Type,
    }
  • Trait bounds are no longer inferred on fields whose value is shadowed by an explicit named argument in a format message (#​345)

    // Before: impl<T: Octal> Display for Error<T>
    // After: impl<T> Display for Error<T>
    #[derive(Error, Debug)]
    #[error("{thing:o}", thing = "...")]
    pub struct Error<T> {
        thing: T,
    }
  • Tuple structs and tuple variants can no longer use numerical {0} {1} access at the same time as supplying extra positional arguments for a format message, as this makes it ambiguous whether the number refers to a tuple field vs a different positional arg (#​354)

    #[derive(Error, Debug)]
    #[error("ambiguous: {0} {}", $N)]
    //                  ^^^ Not allowed, use #[error("... {0} {n}", n = $N)]
    pub struct TupleError(i32);
  • Code containing invocations of thiserror's derive(Error) must now have a direct dependency on the thiserror crate regardless of the error data structure's contents (#​368, #​369, #​370, #​372)

Features

  • Support disabling thiserror's standard library dependency by disabling the default "std" Cargo feature: thiserror = { version = "2", default-features = false } (#​373)

  • Support using r#source as field name to opt out of a field named "source" being treated as an error's Error::source() (#​350)

    #[derive(Error, Debug)]
    #[error("{source} ==> {destination}")]
    pub struct Error {
        r#source: char,
        destination: char,
    }
    
    let error = Error { source: 'S', destination: 'D' };
  • Infinite recursion in a generated Display impl now produces an unconditional_recursion warning (#​359)

    #[derive(Error, Debug)]
    #[error("??? {self}")]
    pub struct Error;
  • A new attribute #[error(fmt = path::to::myfmt)] can be used to write formatting logic for an enum variant out-of-line (#​367)

    #[derive(Error, Debug)]
    pub enum Error {
        #[error(fmt = demo_fmt)]
        Demo { code: u16, message: Option<String> },
    }
    
    fn demo_fmt(code: &u16, message: &Option<String>, formatter: &mut fmt::Formatter) -> fmt::Result {
        write!(formatter, "{code}")?;
        if let Some(msg) = message {
            write!(formatter, " - {msg}")?;
        }
        Ok(())
    }
  • Enums with an enum-level format message are now able to have individual variants that are transparent to supersede the enum-level message (#​366)

    #[derive(Error, Debug)]
    #[error("my error {0}")]
    pub enum Error {
        Json(#[from] serde_json::Error),
        Yaml(#[from] serde_yaml::Error),
        #[error(transparent)]
        Other(#[from] anyhow::Error),
    }

Configuration

📅 Schedule: Branch creation - "before 10am on monday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot enabled auto-merge (squash) November 10, 2024 21:06
Copy link
Contributor Author

renovate bot commented Nov 10, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package [email protected] --precise 2.0.4
    Updating crates.io index
error: failed to select a version for the requirement `thiserror = "^1"`
candidate versions found which didn't match: 2.0.4
location searched: crates.io index
required by package `pnp v0.9.0`
    ... which satisfies dependency `pnp = "^0.9.0"` (locked to 0.9.0) of package `oxc_resolver v2.1.1 (/tmp/renovate/repos/github/oxc-project/oxc-resolver)`
    ... which satisfies path dependency `oxc_resolver` (locked to 2.1.1) of package `oxc_napi_resolver v0.0.0 (/tmp/renovate/repos/github/oxc-project/oxc-resolver/napi)`

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (8d6da48) to head (8ed0c6e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          11       11           
  Lines        2449     2449           
=======================================
  Hits         2374     2374           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #303 will not alter performance

Comparing renovate/major-rust-crates (8ed0c6e) with main (8d6da48)

Summary

✅ 3 untouched benchmarks

@renovate renovate bot force-pushed the renovate/major-rust-crates branch 3 times, most recently from e78b299 to 579d65e Compare November 12, 2024 02:42
@Boshen Boshen marked this pull request as draft November 12, 2024 03:34
auto-merge was automatically disabled November 12, 2024 03:34

Pull request was converted to draft

@renovate renovate bot force-pushed the renovate/major-rust-crates branch 7 times, most recently from 2fffe47 to 9183f5f Compare November 19, 2024 02:42
@renovate renovate bot force-pushed the renovate/major-rust-crates branch 14 times, most recently from 3ad39e2 to d29d6ee Compare November 24, 2024 22:01
@renovate renovate bot force-pushed the renovate/major-rust-crates branch 6 times, most recently from e3ebe7f to 6df60ea Compare December 2, 2024 21:49
@renovate renovate bot force-pushed the renovate/major-rust-crates branch 2 times, most recently from c47f7a0 to 36cbc83 Compare December 5, 2024 13:56
@renovate renovate bot force-pushed the renovate/major-rust-crates branch from 36cbc83 to eba274f Compare December 5, 2024 14:10
Copy link
Contributor Author

renovate bot commented Dec 5, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Contributor Author

renovate bot commented Dec 5, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@renovate renovate bot changed the title chore(deps): update rust crate thiserror to v2 chore(deps): update rust crate thiserror to v2 - abandoned Dec 5, 2024
@Boshen Boshen closed this Dec 5, 2024
@Boshen Boshen marked this pull request as ready for review December 5, 2024 16:03
@Boshen Boshen deleted the renovate/major-rust-crates branch December 5, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant