Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with ESPHome 2023.4 #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joshuaspence
Copy link
Contributor

Fixes #39. Since ESPHome 2023.4 the stream_server component doesn't listen on the specified port. I think this was broken by esphome/esphome#4574.

Since ESPHome 2023.4 the `stream_server` component doesn't listen on the specified port. I think this was broken by esphome/esphome#4574.
Copy link
Owner

@oxan oxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged the first commit to fix the compatibility issues with 2023.4 (thanks!), but I've a few comments on the second one.

components/stream_server/stream_server.cpp Outdated Show resolved Hide resolved
components/stream_server/stream_server.cpp Outdated Show resolved Hide resolved
@joshuaspence joshuaspence requested a review from oxan April 21, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not listening on ESPHome 2023.4
2 participants