Prevent race between update scheduling and set deletion #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a race condition where a set delete request from a peer could invalidate maps while an update is being scheduled. Hold the lock during the entire update submission to ensure maps remains valid.
|
The patch has been tested that it doesn't create deadlock, and the crash has gone away. A small performance evaluation comparing with the code base without the patch has been studied. The 'oversampled' and 'outstanding update' counters are used to see the patch affect on the performance. The counters before and after the patch have insignificant differences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition where a set delete request from a peer could invalidate maps while an update is being scheduled. Hold the lock during the entire update submission to ensure maps remains valid.