-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read models and add 1.19 blocks that can't be dynamically rendered yet #2054
base: master
Are you sure you want to change the base?
Conversation
Should be good enough for rendering most blocks in future minecraft releases without the need to explicitly implement them. Not really sure how it behaves on different OSes. |
There still seem to be problems with northdirection upper-right and lower-left. Working on it. |
Hey @lieuwestra , any news about the 1.19? |
|
||
return self.models[modelname] | ||
|
||
def build_block_from_model(self, modelname, blockstate={}): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI there's a recursion error creating textures for worlds created after 1.19.3 that's being caused by the new experimental chiseled bookshelf models added for 1.20.
I haven't had time to look into this more deeply, but for now this suggestion will skip building the problematic models:
def build_block_from_model(self, modelname, blockstate={}): | |
def build_block_from_model(self, modelname, blockstate={}): | |
if 'chiseled_bookshelf' in modelname: | |
return |
FYI from the projects main read me. PLEASE NOTE: Overviewer is currently unmaintained. PRs will not be merged and issues will not be addressed. The website and repository will remain online and accessible. |
Stable as far as I'm concerned. If you want 1.19 blocks you can safely use this.
What I'm not going to deal with for now