Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Merge local bunfig with action scope/registry config #39

Conversation

vitoorgomes
Copy link
Contributor

@vitoorgomes vitoorgomes commented Nov 16, 2023

Auth is now able to merge local config with the necessary scope + registry url without duplicating or doing some weird things when a local config already exists.

It covers:

  • No local bunfig.toml
  • When local bunfig.toml does not have any [install.scopes]
  • When local bunfig.toml does have a [install.scopes] and it's not the same as the action
  • When local bunfig.toml does have a [install.scopes] and it's the same as the action

It will be able to merge all without conflicting keys

#33

I also created some tests and added to the github actions as a new step

@vitoorgomes vitoorgomes force-pushed the feat/merge-local-bunfig-with-scope-action branch from d7922f5 to 8c0b797 Compare November 16, 2023 19:23
@xhyrom
Copy link
Collaborator

xhyrom commented Nov 17, 2023

Thanks you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants