Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Rewrite to avoid conflicts and allow for doc generation #18024

Merged
merged 106 commits into from
Mar 25, 2025

Conversation

alii
Copy link
Member

@alii alii commented Mar 9, 2025

What does this PR do?

This PR rearranges all of bun-types to in a way that eliminates conflicts with Node.js AND lib.dom.d.ts, as well as declaring the Bun namespace and other symbols in a way we can generate documentation from.

Fixes #13599
Fixes #8761
Fixes #13167
Fixes #17203
Fixes #17256
Fixes #13858
Fixes #16044
Fixes #18458
Fixes #17980
Fixes #14660
Fixes #8765
Fixes #17940
Fixes #16785
Fixes #16537
Fixes #14892
Fixes #13669
Fixes #12662
Fixes #358

todo:

  • rewrite the types
  • publish @oven/typescript-bun-lib-dom
  • figure out CI for autopatching dom..? (might not be necessary)
  • see if we can get BodyInit & HeadersInit to be declared inside of Bun types, not dom

Sorry, something went wrong.

@robobun
Copy link

robobun commented Mar 9, 2025

Updated 9:26 AM PT - Mar 25th, 2025

@alii, your commit 6800a90 has 2 failures in Build #13907:


🧪   try this PR locally:

bunx bun-pr 18024

@alii
Copy link
Member Author

alii commented Mar 25, 2025

@Jarred-Sumner it seems like the failing tests are unrelated to changes in this PR. How can we resolve?

@Jarred-Sumner
Copy link
Collaborator

Jarred-Sumner commented Mar 25, 2025 via email

@RiskyMH RiskyMH added the types An issue with TypeScript types label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment