Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+5 passing node:zlib tests #15944

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

+5 passing node:zlib tests #15944

wants to merge 5 commits into from

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Dec 22, 2024 •
edited
Loading

What does this PR do?

+5 passing node:zlib tests

  • This fixes a memory leak in node:zlib caused by keeping strong references to the callbacks and the this value when it wasn't necessary
  • This fixes the callbacks being associated with the wrong class (!)
  • This fixes a memory leak that could potentially occur where the stream was initialized but never freed (or never closed)

How did you verify your code works?

Ran existing node tests and verified they pass

@Jarred-Sumner Jarred-Sumner requested a review from nektro December 22, 2024 16:22
@robobun
Copy link

robobun commented Dec 22, 2024 •
edited
Loading

Updated 10:12 AM PT - Dec 22nd, 2024

✅ @Jarred-Sumner, your commit b77d569 has passed in #8423! 🎉

🧪   try this PR locally:

bunx bun-pr 15944

@Jarred-Sumner Jarred-Sumner changed the title +4 passing node:zlib tests +5 passing node:zlib tests Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nektro nektro Awaiting requested review from nektro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarred-Sumner @robobun