Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Get closer to cross-compile darwin-x64 on darwin-aarch64 #15918

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Electroid
Copy link
Contributor

What does this PR do?

This does not enable cross-complication. However, it fixes various CI things.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@robobun
Copy link

robobun commented Dec 21, 2024

Updated 6:34 PM PT - Dec 20th, 2024

@Electroid, your commit 0d34fae has passed in #8373! 🎉


🧪   try this PR locally:

bunx bun-pr 15918

Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff removing usages of the CPU macro is a CI configuration issue. Many more things will break if the CPU() macro is not working correctly. The code will likely not load at runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants