DNS fixes #15864

heimskr · 2024-12-19T02:02:57Z

What does this PR do?

Adds some DNS tests and the changes that caused them to start passing.

Documentation or TypeScript types
Code changes

How did you verify your code works?

Added tests from Node.

…lers

robobun · 2024-12-19T02:03:07Z

^{Updated 5:33 PM PT - Dec 20th, 2024}

❌ @heimskr, your commit 606b05f has 37 failures in #8363:

test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 3.20 x64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x72202020200a4b on 🐧 12 aarch64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x72202020200a4b on 🐧 22.04 aarch64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x72202020200a4b on 🐧 20.04 aarch64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 22.04 x64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 12 x64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 20.04 x64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 24.04 x64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 24.04 x64-baseline
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 22.04 x64-baseline
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 12 x64-baseline
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 20.04 x64-baseline
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x72202020200a4b on 🐧 24.04 aarch64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🐧 3.20 x64-baseline
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🍎 14 x64
test/regression/issue/ctrl-c.test.ts - segmentation fault at address 0x0 on 🍎 13 x64
test/js/node/test/parallel/test-dns-channel-cancel-promise.js - segmentation fault at address 0x2caf28035d88 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-dns-channel-cancel-promise.js - segmentation fault at address 0x2bd079fa5aa0 on 🐧 3.20 x64
test/js/node/test/parallel/test-dns-channel-cancel-promise.js - segmentation fault at address 0x33b295fa5b30 on 🐧 3.20 x64-baseline
test/js/third_party/grpc-js/test-server.test.ts - segmentation fault on 🐧 3.20 aarch64
test/js/third_party/grpc-js/test-server.test.ts - segmentation fault on 🐧 3.20 x64
test/js/third_party/grpc-js/test-server.test.ts - segmentation fault on 🐧 12 aarch64
test/js/third_party/grpc-js/test-server.test.ts - segmentation fault on 🐧 12 x64
test/js/third_party/grpc-js/test-server.test.ts - segmentation fault on 🐧 12 x64-baseline
test/js/third_party/grpc-js/test-server.test.ts - segmentation fault on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x7073202c636e79 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 3.20 x64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x7073202c636e89 on 🐧 12 aarch64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x7073202c636e89 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x7073202c636e89 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 22.04 x64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 12 x64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 24.04 x64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 20.04 x64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x7073202c636e89 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-dgram-send-callback-multi-buffer-empty-address.js - segmentation fault at address 0x0 on 🐧 3.20 x64-baseline
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 3.20 aarch64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 3.20 x64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 12 aarch64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 20.04 aarch64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 24.04 aarch64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 22.04 aarch64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 12 x64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 24.04 x64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 20.04 x64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 22.04 x64
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 22.04 x64-baseline
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 12 x64-baseline
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 20.04 x64-baseline
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 24.04 x64-baseline
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🐧 3.20 x64-baseline
test/js/third_party/grpc-js/test-resolver.test.ts - segmentation fault on 🍎 14 x64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x7073202c636e79 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 3.20 x64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x7073202c636e89 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x7073202c636e89 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x7073202c636e89 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x7073202c636e89 on 🐧 12 aarch64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 22.04 x64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 24.04 x64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 12 x64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 20.04 x64
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-dgram-send-callback-buffer-length.js - segmentation fault at address 0x0 on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x7073202c636e79 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 3.20 x64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x7073202c636e89 on 🐧 12 aarch64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x7073202c636e89 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x7073202c636e89 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 12 x64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 24.04 x64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 22.04 x64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 20.04 x64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x7073202c636e89 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-dgram-connect-send-multi-buffer-copy.js - segmentation fault at address 0x0 on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-dns-channel-cancel.js - segmentation fault at address 0x172941f95bb0 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-dns-channel-cancel.js - segmentation fault at address 0x33ce91f95aa0 on 🐧 3.20 x64
test/js/node/test/parallel/test-dns-channel-cancel.js - segmentation fault at address 0x2e2cf3f95bb0 on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x7073202c636e79 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 3.20 x64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x7073202c636e89 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x7073202c636e89 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x7073202c636e89 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x7073202c636e89 on 🐧 12 aarch64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 22.04 x64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 12 x64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 24.04 x64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 20.04 x64
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-dgram-connect-send-empty-buffer.js - segmentation fault at address 0x0 on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x7073202c636e79 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 3.20 x64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x7073202c636e89 on 🐧 12 aarch64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x7073202c636e89 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x7073202c636e89 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x7073202c636e89 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 12 x64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 22.04 x64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 20.04 x64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 24.04 x64
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-array.js - segmentation fault at address 0x0 on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x7073202c636e79 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 3.20 x64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x7073202c636e89 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x7073202c636e89 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x7073202c636e89 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x7073202c636e89 on 🐧 12 aarch64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 24.04 x64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 12 x64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 22.04 x64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 20.04 x64
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-cb-quelches-error.js - segmentation fault at address 0x0 on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x7073202c636e79 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 3.20 x64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x7073202c636e89 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x7073202c636e89 on 🐧 12 aarch64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x7073202c636e89 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x7073202c636e89 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 12 x64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 20.04 x64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 24.04 x64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 22.04 x64
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-dgram-send-empty-packet.js - segmentation fault at address 0x0 on 🐧 3.20 x64-baseline

🧪 try this PR locally:

bunx bun-pr 15864

TODO: ref the DNSResolvers when creating promises

heimskr added 25 commits December 12, 2024 17:43

Add dns.setServers

98d2a9e

Special case for falsey hostnames in dns.lookup

8052a0e

Add an argument to ERR_INVALID_IP_ADDRESS

5587ac0

Expose AI_ALL, AI_ADDRCONFIG and AI_V4MAPPED from netdb.h under dns

d3b13e3

Better DNS lookup

69a5b10

Better DNS error objects

9019d7a

Initial work on dns.Resolver isolation

9a15f30

Isolated resolution

5ab64c0

Implement resolveAny via horrible callback hell

a5805bc

CAA record support

f5cc373

Glorious promises

c729dbb

Remove a comment that's not quite true anymore

8bafda4

Simplify some Zig

130aa1b

Some dns.ts fixes

a62e2dc

Simplify some Zig again

56b5141

Isolate promisified Resolver objects

b2a76cc

No more NAPTR in resolveAny

c7c22c4

There isn't actually a _socket parameter to dgram sockets' error hand…

e8e19c7

…lers

Add ENOSERVER

f4e30f9

Don't do regular lookup for A/AAAA

01e9cbf

Merge branch 'main' of github.com:oven-sh/bun into kai/dns-test-fixes

e2d9f59

Fix A record resolution

35a0c6d

Add test-dns.js

ec09c1f

Add test-dns-get-server.js

e2160db

Customizable timeout and tries options for DNS resolvers

3aa930e

heimskr requested review from a team and zackradisic and removed request for a team December 19, 2024 02:06

Fix Windows compilation probably

89499ad

Include ws2def.h instead of netdb.h on Windows

9df2f83

Jarred-Sumner requested review from a team and cirospaciari and removed request for zackradisic and a team December 19, 2024 03:08

heimskr added 11 commits December 19, 2024 15:11

Add+fix test-dns-lookup.js

ae79ce2

Don't overwrite "name" properties of warning objects

eff93bd

Honor type and code parameters of process.emitWarning

a8d1082

Properly emit invalid hostname warnings

c9438ff

Add test-dns-lookupService.js

0e6bdaf

Implement Resolver.cancel()

a415b60

Add test-dns-channel-cancel-promise.js

9047047

Per-resolver reversing

922050c

Initial work on DNS timeout support

166a55a

TODO: ref the DNSResolvers when creating promises

Proper refcounting for DNSResolvers

8bf4542

Fix test-dns.js

606b05f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DNS fixes #15864

DNS fixes #15864

heimskr commented Dec 19, 2024

robobun commented Dec 19, 2024 •

edited

Loading

DNS fixes #15864

Are you sure you want to change the base?

DNS fixes #15864

Conversation

heimskr commented Dec 19, 2024

What does this PR do?

How did you verify your code works?

robobun commented Dec 19, 2024 • edited Loading

robobun commented Dec 19, 2024 •

edited

Loading