more random bindgen features #15832
Open
more random bindgen features #15832
+1,654
−471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 6:32 PM PT - Dec 19th, 2024
❌ @paperdave, your commit b8f9a8a has some failures in 🧪 try this PR locally: bunx bun-pr 15832 |
|
|
||
| JSC::EncodedJSValue throwNodeInvalidArgTypeErrorForBindgen(JSC::ThrowScope& throwScope, JSC::JSGlobalObject* globalObject, const WTF::ASCIILiteral& arg_name, const WTF::ASCIILiteral& expected_type, JSC::JSValue val_actual_value) | ||
| { | ||
| auto actual_value = Bun::JSValueToStringSafe(globalObject, val_actual_value); |
There was a problem hiding this comment.
haven't seen this function, is handling Symbol what makes it safe?
There was a problem hiding this comment.
it is what ErrorCode.cpp has
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
| writer.print("{}", .{value.toFmt(&formatter)}) catch return ZigString.Empty; | ||
| buffered_writer.flush() catch return ZigString.Empty; | ||
|
|
||
| return ZigString.init(array.slice()).withEncoding(); |
There was a problem hiding this comment.
what frees this memory?
| @@ -624,6 +623,30 @@ pub const StringOrBuffer = union(enum) { | |||
| }; | |||
| return fromJSWithEncodingMaybeAsync(global, allocator, value, encoding, maybe_async); | |||
| } | |||
|
|
|||
| pub fn validateForBindgen(value: JSC.JSValue) bool { | |||
There was a problem hiding this comment.
this is a bit confusing
| @@ -217,34 +216,132 @@ WTF::String JSValueToStringSafe(JSC::JSGlobalObject* globalObject, JSValue arg) | |||
| } | |||
| } | |||
|
|
|||
| return arg.toWTFStringForConsole(globalObject); | |||
| ZigString zstring = Bun__inspect(globalObject, arg); | |||
| BunString bstring(BunStringTag::ZigString, BunStringImpl(zstring)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i had these on stash earlier, this adds new types:
other changes