Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: test pause/resume readable side #15820

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: test pause/resume readable side #15820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/http.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,7 @@ fn NewHTTPContext(comptime ssl: bool) type {
socket.flush();
socket.timeout(0);
socket.setTimeoutMinutes(5);
_ = socket.pauseStream();

pending.http_socket = socket;
pending.did_have_handshaking_error_while_reject_unauthorized_is_false = did_have_handshaking_error_while_reject_unauthorized_is_false;
Expand Down Expand Up @@ -1005,6 +1006,7 @@ fn NewHTTPContext(comptime ssl: bool) type {
ctx.* = bun.cast(**anyopaque, ActiveSocket.init(client).ptr());
}
client.allow_retry = true;
_ = sock.resumeStream();
client.onOpen(comptime ssl, sock);
if (comptime ssl) {
client.firstCall(comptime ssl, sock);
Expand Down Expand Up @@ -3615,16 +3617,18 @@ pub fn onData(
}
}
},

.fail => {},
.proxy_headers, .proxy_handshake => {
this.setTimeout(socket, 5);
if (this.proxy_tunnel) |proxy| {
proxy.receiveData(incoming_data);
}
return;
},
else => {
.fail => {}, // already fail just ignore
.done, .proxy_body => {
// .proxy_body is a invalid state should only be reachable on request side
bun.debugAssert(this.state.response_stage == .done);
// we are already done but we receive extra data, the socket may be in a invalid http state after this so we close
this.state.pending_response = null;
this.closeAndFail(error.UnexpectedData, is_ssl, socket);
return;
Expand Down
Loading