Fixes #15784 #15809
Draft
Fixes #15784 #15809
+56
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 10:08 PM PT - Dec 16th, 2024
✅ @Jarred-Sumner, your commit b6bd724 has passed in 🧪 try this PR locally: bunx bun-pr 15809 |
Jarred-Sumner
commented
Dec 17, 2024
| ) struct { cache_dir: std.fs.Dir, cache_dir_subpath: stringZ } { | ||
| const name = pkg_name; | ||
| const buf = manager.lockfile.buffers.string_bytes.items; | ||
| const buf = lockfile.buffers.string_bytes.items; |
There was a problem hiding this comment.
this was the bug i think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #15784
I believe the bug was the
Lockfilepointer was to the one on thePackageManager(manager.lockfile) instead of the newly allocated one, so when it tries to read a string from string_bytes it points to an entirely different memory address.https://github.com/oven-sh/bun/pull/15809/files#diff-2d4db027e059280840de7dfe46dda1752467e66c1c3014369ed701b026cd06fcR3995-R3999
How did you verify your code works?
WIP.