Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: url 100% #15752

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

compat: url 100% #15752

wants to merge 2 commits into from

Conversation

snoglobe
Copy link
Contributor

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@snoglobe snoglobe changed the title compat: url 100$ compat: url 100% Dec 14, 2024
@robobun
Copy link

robobun commented Dec 14, 2024

@snoglobe, your commit a93ce9f has 33 failures in #7950:

  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - timeout on 🐧 12 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 12 aarch64
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 20.04 aarch64
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 22.04 aarch64
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 12 x64-baseline
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 20.04 x64-baseline
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 22.04 x64-baseline
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 24.04 x64-baseline
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 22.04 x64
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 20.04 x64
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 24.04 x64
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 12 x64
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 3.20 aarch64
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 3.20 x64-baseline
  • test/js/third_party/remix/remix.test.ts - annotation error on 🐧 3.20 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 12 aarch64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 20.04 aarch64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 aarch64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 24.04 aarch64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 24.04 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 12 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 20.04 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 24.04 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 12 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 20.04 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 aarch64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 x64
  • test/regression/issue/ctrl-c.test.ts - 1 failing on 🐧 24.04 x64
  • test/regression/issue/09041.test.ts - 1 failing on 🐧 24.04 x64
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 24.04 aarch64
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 22.04 x64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 24.04 x64-baseline
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 22.04 x64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 20.04 x64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/bun/css/doesnt_crash.test.ts - 1 failing on 🐧 24.04 aarch64
  • test/js/node/test/parallel/test-timers-immediate-queue.js - code 1 on 🐧 24.04 aarch64
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 24.04 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64-baseline
  • test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64
  • test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64-baseline
  • test/js/node/fs/fs.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/web/url/url.windows.test.js - 3 failing on 🪟 2019 x64
  • test/js/web/url/url.windows.test.js - 3 failing on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64
  • test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/third_party/pino/pino.test.js - 1 failing on 🍎 14 aarch64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🍎 13 aarch64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 12 aarch64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 24.04 aarch64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 24.04 x64-baseline
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 20.04 x64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 22.04 x64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 24.04 x64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/third_party/pino/pino.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/test-event-emitter-method-names.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-event-emitter-method-names.js - code 1 on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🍎 14 aarch64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🍎 13 aarch64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 24.04 aarch64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 20.04 aarch64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 24.04 x64-baseline
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 22.04 x64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 24.04 x64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 20.04 x64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 3.20 x64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🍎 14 aarch64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🍎 13 aarch64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 20.04 aarch64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 24.04 aarch64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 24.04 x64-baseline
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 24.04 x64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 22.04 x64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 20.04 x64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 3.20 x64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🍎 14 aarch64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🍎 13 aarch64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 20.04 aarch64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 24.04 x64-baseline
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 24.04 x64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 22.04 x64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 20.04 x64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 24.04 aarch64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 3.20 x64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🪟 2019 x64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🪟 2019 x64-baseline
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 12 aarch64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 24.04 aarch64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 24.04 x64-baseline
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 12 x64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 24.04 x64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🍎 14 aarch64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🍎 13 aarch64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 24.04 aarch64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 20.04 aarch64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 24.04 x64-baseline
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 20.04 x64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 24.04 x64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 22.04 x64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 3.20 x64
  • @snoglobe
    Copy link
    Contributor Author

    snoglobe commented Dec 14, 2024

    TODO:

    • modify tests to not require node:test
    • clean up code

    @kravetsone
    Copy link

    TODO:

    • modify tests to not require node:test
    • clean up code

    Did Bun plans to do node:test shim?
    Looks fine for cross-runtime tests

    @jbergstroem
    Copy link
    Contributor

    Did Bun plans to do node:test shim? Looks fine for cross-runtime tests

    #5090

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants