-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow WTF timers to participate in the event loop #15557
Draft
190n
wants to merge
29
commits into
main
Choose a base branch
from
ben/wtf-timer-event-loop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 11:14 AM PT - Dec 22nd, 2024
❌ @Jarred-Sumner, your commit eea51d9 has some failures in 🧪 try this PR locally: bunx bun-pr 15557 |
…o ben/wtf-timer-event-loop
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WebKit has
WTF::RunLoop
andWTF::RunLoop::Timer
. The latter is created in order to run GC at certain intervals. Since Bun's event loop is really in charge of timers, rather than the RunLoop, the GC timers would previously never run. This PR enables Bun to include those timers in the event loop and fire them at the right times.This also includes the change from #14885 to release heap access while waiting for events.
TODO:
GarbageCollectionController
fromevent_loop.zig
Requires oven-sh/WebKit#71 and #15328
How did you verify your code works?
TODO