zig: make throwTODO use JSError #15264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2305,7 +2305,7 @@ fn NewSocket(comptime ssl: bool) type { | |||
| const length_value = args[2]; | |||
|
|
|||
| if (encoding_value != .undefined and (offset_value != .undefined or length_value != .undefined)) { | |||
| globalObject.throwTODO("Support encoding with offset and length altogether. Only either encoding or offset, length is supported, but not both combinations yet."); | |||
| globalObject.throwTODO("Support encoding with offset and length altogether. Only either encoding or offset, length is supported, but not both combinations yet.") catch {}; | |||
There was a problem hiding this comment.
Shouldn't we change writeOrEnd to have an error union return type instead of catch {};? Same with stdio.zig extract?
There was a problem hiding this comment.
perhaps, yeah it seems this whole function is using .fail for exceptions
@cirospaciari would likely know more on the prospect of that change
Co-authored-by: Dylan Conway <[email protected]>
dylan-conway
approved these changes
Nov 20, 2024
snoglobe
pushed a commit
that referenced
this pull request
Nov 21, 2024
Co-authored-by: Dylan Conway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress towards #15141