Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start fixing bugs discovered by Node.js's Node-API tests #14501

Draft
wants to merge 200 commits into
base: main
Choose a base branch
from
Draft

Start fixing bugs discovered by Node.js's Node-API tests #14501

wants to merge 200 commits into from
+26,927 −3,117

Commits on Jul 19, 2024

  1. Defer finalization for napi callbacks to the immediate task queue

    @Jarred-Sumner
    Jarred-Sumner committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1f53597 View commit details
    Browse the repository at this point in the history

  2. Apply formatting changes

    @Jarred-Sumner @github-actions
    Jarred-Sumner authored and github-actions[bot] committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    4181393 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'main' into jarred/napi-2

    @dylan-conway
    dylan-conway authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    eb8d465 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Merge branch 'main' into jarred/napi-2

    @190n
    190n committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e66ec2a View commit details
    Browse the repository at this point in the history

  2. Fix tsfn finalizers

    @190n
    190n committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    dfa2a6b View commit details
    Browse the repository at this point in the history

  3. Make NAPI tests allocate in the finalizer

    @190n
    190n committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2583f33 View commit details
    Browse the repository at this point in the history

  4. Route all finalizers through NapiFinalizer

    @190n
    190n committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    afcf7b1 View commit details
    Browse the repository at this point in the history

  5. Test that threadsafe function finalizers run on the next tick

    @190n
    190n committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    23dc0fe View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Fix bugs in napi_create_class and napi_get_value_bigint_*

    @190n
    190n committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    85f617f View commit details
    Browse the repository at this point in the history

  2. Fix bugs with napi_define_class

    @190n
    190n committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    6169f10 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6a440aa View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. WIP convert napi.cpp functions to set the last error

    @190n
    190n committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ef4728c View commit details
    Browse the repository at this point in the history

  2. Set last error in all C++ napi functions

    @190n
    190n committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    49b2de9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1649c03 View commit details
    Browse the repository at this point in the history

  4. Fix napi_create_bigint_words error handling

    @190n
    190n committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a0c2a73 View commit details
    Browse the repository at this point in the history

  5. Arg checking in napi_define_class

    @190n
    190n committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ed4175b View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Fix napi_coerce_to_*

    @190n
    190n committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    216e5b3 View commit details
    Browse the repository at this point in the history

  2. Change sizeof division to std::size

    @190n
    190n committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2fee09f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Move napi_get_value_string_{latin1,utf16} to C++

    @190n
    190n committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b773e66 View commit details
    Browse the repository at this point in the history

  2. Set error code in Zig napi functions

    @190n
    190n committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2d0e0c9 View commit details
    Browse the repository at this point in the history

  3. Fix napi_create_dataview

    @190n
    190n committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7be1bf3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8c571d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. WIP supporting napi_wrap for more values

    @190n
    190n committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6d1db2c View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. napi_wrap WIP + rip out NAPICallFrame tagging

    @190n
    190n committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ea1ddb2 View commit details
    Browse the repository at this point in the history

  2. More (self-contained for now) napi tests

    @190n
    190n committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5bae294 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e5ffd66 View commit details
    Browse the repository at this point in the history

  2. Pass data pointer to NAPI constructors

    @190n
    190n committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a240093 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. clangd config for NAPI tests

    @190n
    190n committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    020c32b View commit details
    Browse the repository at this point in the history

  2. Misc CallFrame fixes

    @190n
    190n committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d612cff View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e5e643d View commit details
    Browse the repository at this point in the history

  4. Do not propagate nullptr out of NAPIFunction::call

    @190n
    190n committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c44eb73 View commit details
    Browse the repository at this point in the history

  5. Delete NapiPrototype::napiRef

    @190n
    190n committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    710f779 View commit details
    Browse the repository at this point in the history

  6. JS exceptions instead of assertions in napi tests

    @190n
    190n committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b2080c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Split NAPI tests out of the huge C++ file

    @190n
    190n committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a7bc53b View commit details
    Browse the repository at this point in the history

  2. Fix providing class's data pointer to method without data pointer

    @190n
    190n committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b753e4b View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. napi_wrap fixes

    @190n
    190n committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b8aba83 View commit details
    Browse the repository at this point in the history

  2. Refine NAPI tests

    @190n
    190n committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    bdcca41 View commit details
    Browse the repository at this point in the history

  3. Work on leak testing for NAPI wrap/ref/external

    @190n
    190n committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e04f461 View commit details
    Browse the repository at this point in the history

  4. Add missing #include

    @190n
    190n committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d29e72f View commit details
    Browse the repository at this point in the history

  5. Add filename to napi_log

    @190n
    190n committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f71b440 View commit details
    Browse the repository at this point in the history

  6. Fix napi_ref finalizers

    @190n
    190n committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    600bc1c View commit details
    Browse the repository at this point in the history

  7. Stress test napi_wrap and napi_external

    @190n
    190n committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    3ba398f View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Fix NAPI tests compiling on Windows

    @190n
    190n committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    43d7cfc View commit details
    Browse the repository at this point in the history

  2. Add napi_type_tag_object and napi_check_type_tag

    @190n
    190n committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    3587391 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Reset last NAPI error before calling into a native module

    @190n
    190n committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c28d419 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Fix NAPI bugs

    @190n
    190n committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    71101e1 View commit details
    Browse the repository at this point in the history

  2. Fix NAPI string creation bugs

    @heimskr
    heimskr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    249227d View commit details
    Browse the repository at this point in the history

  3. Move napi_create_typedarray from napi.zig to napi.cpp to produce Rang… 

    …eError exceptions
    @heimskr
    heimskr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    39b442b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ben/fix-node-napi-tests

    @heimskr
    heimskr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    528d9a6 View commit details
    Browse the repository at this point in the history

  5. Make napi_create_external_arraybuffer produce a non-shared ArrayBuffer

    @heimskr
    heimskr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6999978 View commit details
    Browse the repository at this point in the history

  6. Include all properties except enums in napi_get_property_names, and e… 

    …nsure that the key is a name in napi_has_own_property
    @heimskr
    heimskr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    19b0fed View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Support filtering by property descriptor in napi_get_all_property_names

    @190n
    190n committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    73579e1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    84c4f96 View commit details
    Browse the repository at this point in the history

  3. Rename wrap-lifetime-test.mjs

    @190n
    190n committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8b19e08 View commit details
    Browse the repository at this point in the history

  4. Fix node_api_symbol_for behavior for null description parameters

    @heimskr
    heimskr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    774bb89 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ben/fix-node-napi-tests' of github.com:oven-sh/bun into… 

    … ben/fix-node-napi-tests
    @heimskr
    heimskr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8a0a88c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Replace NAPIFunction with NapiClass

    @heimskr
    heimskr committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    838ca00 View commit details
    Browse the repository at this point in the history

  2. Fix napi_get_new_target

    @heimskr
    heimskr committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    059185f View commit details
    Browse the repository at this point in the history

  3. Fix some confusion over the "length" parameter in NapiClass

    @heimskr
    heimskr committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    197a26f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    91a5231 View commit details
    Browse the repository at this point in the history

  5. Build napi-app in debug mode

    @190n
    190n committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a669ff1 View commit details
    Browse the repository at this point in the history

  6. Test napi_set_property and napi_set_named_property

    @190n
    190n committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5176ab5 View commit details
    Browse the repository at this point in the history

  7. Fix property-related NAPI methods

    @heimskr
    heimskr committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fb6a48a View commit details
    Browse the repository at this point in the history

  8. Fix napi_get_all_property_names not including inherited properties wh… 

    …en desired
    @heimskr
    heimskr committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d2c4a9a View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Keep napi_envs separate, keep track of them, associate module info 

    This is so we can check the NAPI version per module and adjust behavior accordingly.
    @heimskr
    heimskr committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    dc4177f View commit details
    Browse the repository at this point in the history

  2. Integrate #12660 into bun/fix-node-napi-tests

    @heimskr
    heimskr committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a1c4240 View commit details
    Browse the repository at this point in the history

  3. Move napi_wrap lifetime test to existing test suite

    @190n
    190n committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    fe18b87 View commit details
    Browse the repository at this point in the history

  4. Fix and test edge cases calling NAPI constructors

    @190n
    190n committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    936ae5a View commit details
    Browse the repository at this point in the history

  5. Remove reference to nonexistent test

    @190n
    190n committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b6dfd89 View commit details
    Browse the repository at this point in the history

  6. Fix napi_set_property

    @190n
    190n committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2d96ec0 View commit details
    Browse the repository at this point in the history

  7. Handle exceptions in NAPI finalizers as uncaught exceptions

    @heimskr
    heimskr committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f15059f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'ben/fix-node-napi-tests' of github.com:oven-sh/bun into… 

    … ben/fix-node-napi-tests
    @heimskr
    heimskr committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    dffc718 View commit details
    Browse the repository at this point in the history

  9. Fix use after free

    @heimskr
    heimskr committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8bb8193 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Clean up some code in node validators (#14897)

    @Jarred-Sumner @190n
    Jarred-Sumner authored and 190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    1293039 View commit details
    Browse the repository at this point in the history

  2. ci: If only tests change, use artifacts from last successful build (#… 

    …14927)
    @Electroid @190n
    Electroid authored and 190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    b5ed0f0 View commit details
    Browse the repository at this point in the history

  3. Fixes #14918 (#14921)

    @Jarred-Sumner @190n
    Jarred-Sumner authored and 190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    664c080 View commit details
    Browse the repository at this point in the history

  4. Add bytesWritten property to Bun.Socket, fix encoding issue in node… 

    …:net (#14516)

Co-authored-by: Ciro Spaciari <[email protected]>
    @Jarred-Sumner @cirospaciari @190n
    2 people authored and 190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    a8a2403 View commit details
    Browse the repository at this point in the history

  5. fix(install): only globally link requested packages (#12506) 

    Co-authored-by: Jarred Sumner <[email protected]>
    @dylan-conway @Jarred-Sumner @190n
    2 people authored and 190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    30fe8d5 View commit details
    Browse the repository at this point in the history

  6. Redact secrets in bunfig.toml and npmrc logs (#14919)

    @dylan-conway @190n
    dylan-conway authored and 190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7fab670 View commit details
    Browse the repository at this point in the history

  7. Fix napi property methods on non-objects (#14935)

    @190n
    190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    08116e4 View commit details
    Browse the repository at this point in the history

  8. Run tests from npm packages, elysia to start (#14932)

    @Electroid @190n
    Electroid authored and 190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    03d945e View commit details
    Browse the repository at this point in the history

  9. Inline process.versions.bun in bun build --compile (#14940)

    @Jarred-Sumner @190n
    Jarred-Sumner authored and 190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7110c07 View commit details
    Browse the repository at this point in the history

  10. Fixes #11754 (#14948)

    @Jarred-Sumner @190n
    Jarred-Sumner authored and 190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    1d5da9e View commit details
    Browse the repository at this point in the history

  11. Fix remaining error in NAPI property functions

    @190n
    190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    afd023a View commit details
    Browse the repository at this point in the history

  12. Fix NAPI property tests

    @190n
    190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7a20f51 View commit details
    Browse the repository at this point in the history

  13. Fix errors from rebase

    @190n
    190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    066b1da View commit details
    Browse the repository at this point in the history

  14. Work on NAPI leak tests

    @190n
    190n committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e3b5927 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d8557ea View commit details
    Browse the repository at this point in the history

  2. Improve finalizer support

    @heimskr
    heimskr committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3303a5d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ben/fix-node-napi-tests' of github.com:oven-sh/bun into… 

    … ben/fix-node-napi-tests
    @heimskr
    heimskr committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a60ae54 View commit details
    Browse the repository at this point in the history

  4. Require key to be a string or symbol in napi_has_own_property

    @heimskr
    heimskr committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c659b3b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Use WebKit branch kai/inherited-property-names

    @heimskr
    heimskr committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ce46947 View commit details
    Browse the repository at this point in the history

  2. Don't require node_api_module_get_api_version_v1, default to version 8

    @heimskr
    heimskr committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a6d707a View commit details
    Browse the repository at this point in the history

  3. Fix multiple dispatch of beforeExit

    @heimskr
    heimskr committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1c06dbd View commit details
    Browse the repository at this point in the history

  4. Fix some formatting

    @heimskr
    heimskr committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f5dc049 View commit details
    Browse the repository at this point in the history

  5. Add a typedef for node_api_basic_env in napi-app

    @heimskr
    heimskr committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ab92fc5 View commit details
    Browse the repository at this point in the history

  6. Fix napi_instanceof

    @heimskr
    heimskr committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3296a6e View commit details
    Browse the repository at this point in the history

  7. Clear NAPI error after native function invocations

    @heimskr
    heimskr committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d4b7102 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Fix napi_get_version misunderstanding

    @heimskr
    heimskr committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    07a217f View commit details
    Browse the repository at this point in the history

  2. Defer external (array)buffer finalizers if necessary

    @heimskr
    heimskr committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    71f3089 View commit details
    Browse the repository at this point in the history

  3. oops

    @heimskr
    heimskr committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0dce736 View commit details
    Browse the repository at this point in the history

  4. Fix napi_get_buffer_info return code

    @heimskr
    heimskr committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7978505 View commit details
    Browse the repository at this point in the history

  5. Add node_api_create_buffer_from_arraybuffer

    @heimskr
    heimskr committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    80b7426 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Fix napi_env usage in FFI

    @heimskr
    heimskr committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a152557 View commit details
    Browse the repository at this point in the history

  2. Add node_api_get_module_file_name

    @heimskr
    heimskr committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0f29267 View commit details
    Browse the repository at this point in the history

  3. Fix typedef in napi-app

    @heimskr
    heimskr committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    85dcebe View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Don't dlclose if node_api_module_get_api_version_v1 is missing

    @heimskr
    heimskr committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    fceeb22 View commit details
    Browse the repository at this point in the history

  2. Use node_api_post_finalizer in napi-app and add some missing includes

    @heimskr
    heimskr committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    855b710 View commit details
    Browse the repository at this point in the history

  3. Fix more missing includes in napi-app

    @heimskr
    heimskr committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c30ef2c View commit details
    Browse the repository at this point in the history

  4. Escape NAPI file:// URIs

    @heimskr
    heimskr committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    07a3913 View commit details
    Browse the repository at this point in the history

  5. Adjust some NAPI error messages to match Node equivalents

    @heimskr
    heimskr committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    9f3b0f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Update WebKit version

    @heimskr
    heimskr committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    7c13e63 View commit details
    Browse the repository at this point in the history

  2. Fix test_reference_by_node_api_version

    @heimskr
    heimskr committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    e34673c View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    86e421a View commit details
    Browse the repository at this point in the history

  2. Set WebKit version to merge commit instead of commit on branch of ove… 

    …n-sh/WebKit#68
    @190n
    190n committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    657f5b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Assert there is an env when calling external finalizer

    @190n
    190n committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    8b5fb34 View commit details
    Browse the repository at this point in the history

  2. Update TODO in napi-app

    @190n
    190n committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1de2319 View commit details
    Browse the repository at this point in the history

  3. Use node_api_post_finalize in napi-app

    @190n
    190n committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3a71be3 View commit details
    Browse the repository at this point in the history

  4. Don't create napi_envs for FFI unless actually needed

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0bee1c9 View commit details
    Browse the repository at this point in the history

  5. Allow null data in napi_async_work

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1d8423e View commit details
    Browse the repository at this point in the history

  6. Remove stray include

    @190n
    190n committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9490c30 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    469be87 View commit details
    Browse the repository at this point in the history

  8. Rename napiEnv FFI symbol to avoid potential collisions

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9ea9925 View commit details
    Browse the repository at this point in the history

  9. Better use of types in FFI.h

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c17e05c View commit details
    Browse the repository at this point in the history

  10. Don't needlessly tick the event loop if the napi finalizer queue is e… 

    …mpty
    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    09a6a11 View commit details
    Browse the repository at this point in the history

  11. Address some feedback

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7993f4f View commit details
    Browse the repository at this point in the history

  12. Fix napi module file URIs

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bd45a65 View commit details
    Browse the repository at this point in the history

  13. Remove defer parameter from NapiRef constructor

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2335e35 View commit details
    Browse the repository at this point in the history

  14. Derefcountify NapiFinalizer

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6e7240b View commit details
    Browse the repository at this point in the history

  15. Address more feedback

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    563b3c0 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'ben/fix-node-napi-tests' into kai/fix-node-napi-tests

    @heimskr
    heimskr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d11a483 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Make parameter const

    @190n
    190n authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    83f536f View commit details
    Browse the repository at this point in the history

  2. Treat a call to process.exit() inside napi_call_function as if it thr… 

    …ew an exception
    @heimskr
    heimskr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    86d4dbe View commit details
    Browse the repository at this point in the history

  3. Undo the previous commit and add a TODO about Web Worker termination

    @heimskr
    heimskr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c20c0de View commit details
    Browse the repository at this point in the history

  4. Merge branch 'ben/fix-node-napi-tests' into kai/fix-node-napi-tests

    @heimskr
    heimskr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7b25ce1 View commit details
    Browse the repository at this point in the history

  5. Fix beforeOnExit being dispatched multiple times

    @heimskr
    heimskr committed Nov 13, 2024
    1 Configuration menu
    Copy the full SHA
    a8fa566 View commit details
    Browse the repository at this point in the history

  6. Run some of Node's Node-API tests in CI

    @190n
    190n committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ac8c6f0 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5970006 View commit details
    Browse the repository at this point in the history

  8. Remove console log

    @190n
    190n committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ccd7275 View commit details
    Browse the repository at this point in the history

  9. bun run prettier:extra

    @190n @github-actions
    190n authored and github-actions[bot] committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    440111f View commit details
    Browse the repository at this point in the history

  10. Ensure NapiRef finalizers are called by the time the env is cleaned up

    @heimskr
    heimskr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b11d631 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'ben/fix-node-napi-tests' into kai/fix-node-napi-tests

    @heimskr
    heimskr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d3b509e View commit details
    Browse the repository at this point in the history

  12. Don't defer finalizers if the VM is shutting down

    @heimskr
    heimskr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    adc00e0 View commit details
    Browse the repository at this point in the history

  13. Remove stray iostream include

    @heimskr
    heimskr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f54f4e6 View commit details
    Browse the repository at this point in the history

  14. Compile tests in parallel

    @190n
    190n committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9dbe40d View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8358f4d View commit details
    Browse the repository at this point in the history

  16. Merge branch 'ben/fix-node-napi-tests' into kai/fix-node-napi-tests

    @heimskr
    heimskr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    6dd369e View commit details
    Browse the repository at this point in the history

  17. Actually call instance data finalizers

    @heimskr
    heimskr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    06d37bf View commit details
    Browse the repository at this point in the history

  18. Remove workaround for #15111

    @190n
    190n committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    bb8b465 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Remove stray import

    @190n
    190n committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0e7ed99 View commit details
    Browse the repository at this point in the history

  2. Increase timeout

    @190n
    190n committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    544dd24 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ben/fix-node-napi-tests

    @190n
    190n committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f439dac View commit details
    Browse the repository at this point in the history

  4. Fix compile error

    @190n
    190n committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e11a683 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ben/fix-node-napi-tests' into kai/fix-node-napi-tests

    @heimskr
    heimskr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    83a2c24 View commit details
    Browse the repository at this point in the history

  6. Fix env cleanup hooks

    @heimskr
    heimskr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9fa480c View commit details
    Browse the repository at this point in the history

  7. Fix async cleanup hooks?

    @heimskr
    heimskr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2646ea0 View commit details
    Browse the repository at this point in the history

  8. Skip node-api/test_async_cleanup_hook/test.js because it uses libuv f… 

    …unctions
    @heimskr
    heimskr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ed1f25e View commit details
    Browse the repository at this point in the history

  9. Add typedef for node_api_basic_env in napi tests

    @heimskr
    heimskr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f37df90 View commit details
    Browse the repository at this point in the history

  10. Undo accidental formatting

    @heimskr
    heimskr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    134f66c View commit details
    Browse the repository at this point in the history

  11. Skip compiling Node NAPI tests that we skip running

    @190n
    190n committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2afb5e6 View commit details
    Browse the repository at this point in the history

  12. Use correct path separators on Windows

    @190n
    190n committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    90852a3 View commit details
    Browse the repository at this point in the history

  13. Fix incorrect calling convention usage

    @heimskr
    heimskr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f501143 View commit details
    Browse the repository at this point in the history

  14. Make checkGC fail if running a finalizer during napi env cleanup

    @heimskr
    heimskr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f9718af View commit details
    Browse the repository at this point in the history

  15. Compile Node tests using Node 23 headers

    @190n
    190n committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f73ef54 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Report NAPI assertion failures more forcefully

    @heimskr
    heimskr committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4103b73 View commit details
    Browse the repository at this point in the history

  2. Remove async cleanup hooks from the list after they're called, not be… 

    …fore
    @heimskr
    heimskr committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2aee623 View commit details
    Browse the repository at this point in the history

  3. Don't defer finalizers if not in GC

    @heimskr
    heimskr committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    28830f0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'ben/fix-node-napi-tests' into kai/fix-node-napi-tests

    @heimskr
    heimskr committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d9c8f27 View commit details
    Browse the repository at this point in the history

  5. Use clang 16 to compile Node NAPI tests on CI linux

    @190n
    190n committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e5c5033 View commit details
    Browse the repository at this point in the history

  6. Add logs for NAPI refs and handle scopes

    @190n
    190n committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6603871 View commit details
    Browse the repository at this point in the history

  7. Change how GC is detected

    @heimskr
    heimskr committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    cf960b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Skip test_worker_buffer_callback/test-free-called.js

    @heimskr
    heimskr committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    eef79ce View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Change Windows crash behavior

    @heimskr
    heimskr committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d090501 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ben/fix-node-napi-tests

    @heimskr
    heimskr committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    73e9866 View commit details
    Browse the repository at this point in the history

  3. Cast argument to quick_exit in crash()

    @heimskr
    heimskr committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    3e085b5 View commit details
    Browse the repository at this point in the history

  4. Change abort exit code on Windows

    @heimskr
    heimskr committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ba5490d View commit details
    Browse the repository at this point in the history

  5. Add Bun__crashHandler binding

    @heimskr
    heimskr committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b02fb24 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Typedef napi_env in napi_with_version.h and then use it in the node_a… 

    …pi_basic_env typedef
    @heimskr
    heimskr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d93122a View commit details
    Browse the repository at this point in the history

  2. Node NAPI tests: get clang(++) from $PATH in CI

    @heimskr
    heimskr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c38eca2 View commit details
    Browse the repository at this point in the history

  3. Actually never mind on that last one

    @heimskr
    heimskr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    437d333 View commit details
    Browse the repository at this point in the history

  4. Will this fix the Windows timeout problem?

    @heimskr
    heimskr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7f9935a View commit details
    Browse the repository at this point in the history

  5. Or maybe this might

    @heimskr
    heimskr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5949777 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into ben/fix-node-napi-tests

    @heimskr
    heimskr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    1e649b4 View commit details
    Browse the repository at this point in the history

  7. Fix leak in napi_threadsafe_function

    @190n
    190n committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b0a30ca View commit details
    Browse the repository at this point in the history

  8. Disable part of js-native-api/test_instance_data/test.js

    @heimskr
    heimskr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    01bbe30 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'ben/fix-node-napi-tests' of github.com:oven-sh/bun into… 

    … ben/fix-node-napi-tests
    @heimskr
    heimskr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    dec572e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Add test for napi_threadsafe_function memory leak

    @190n
    190n committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6ba0563 View commit details
    Browse the repository at this point in the history

  2. Fix napi_threadsafe_function memory leak with fixed queue size

    @190n
    190n committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7a73f14 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Flush stdout explicitly in test_cleanup_hook

    @heimskr
    heimskr committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    24a3f96 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ben/fix-node-napi-tests' of github.com:oven-sh/bun into… 

    … ben/fix-node-napi-tests
    @heimskr
    heimskr committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    2406936 View commit details
    Browse the repository at this point in the history

  3. Skip test_callback_scope/test.js on Windows

    @heimskr
    heimskr committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b191968 View commit details
    Browse the repository at this point in the history

  4. Allow ten minutes for compiling node-napi tests

    @heimskr
    heimskr committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e0414d0 View commit details
    Browse the repository at this point in the history

  5. Maybe increase the timeout with setDefaultTimeout too

    @heimskr
    heimskr committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    30eda1e View commit details
    Browse the repository at this point in the history

  6. Revert "Maybe increase the timeout with setDefaultTimeout too" 

    This reverts commit 30eda1e.
    @heimskr
    heimskr committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8169061 View commit details
    Browse the repository at this point in the history

  7. Add Prisma leak test from #15289

    @190n
    190n committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9426039 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'ben/fix-node-napi-tests' of github.com:oven-sh/bun into… 

    … ben/fix-node-napi-tests
    @heimskr
    heimskr committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f78ac63 View commit details
    Browse the repository at this point in the history

  9. Print compilation progress in node-napi.test.ts

    @heimskr
    heimskr committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7a623fe View commit details
    Browse the repository at this point in the history

  10. Increase napi timeout

    @heimskr
    heimskr committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3fc6ad4 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Reenable Worker test in js-native-api/test_instance_data/test.js

    @heimskr
    heimskr committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e817928 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Fix setRawMode return value on Windows

    @heimskr
    heimskr committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    7886182 View commit details
    Browse the repository at this point in the history