Enable vhosts hotplugs. #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-fne
force-pushed
the
fne-vhosts
branch
4 times, most recently
from
f36f546
to
f2b5210
Compare
outscale-fne
force-pushed
the
fne-vhosts
branch
2 times, most recently
from
30e6119
to
0dbb6aa
Compare
outscale-fne
force-pushed
the
fne-vhosts
branch
7 times, most recently
from
5915deb
to
9c99d22
Compare
outscale-fne
force-pushed
the
fne-vhosts
branch
from
22fb048
to
4da028f
Compare
outscale-fne
force-pushed
the
fne-vhosts
branch
6 times, most recently
from
a2c9a7b
to
f3cc0f1
Compare
outscale-mgo
requested changes
Nov 2, 2020
outscale-fne
force-pushed
the
fne-vhosts
branch
from
57c0a71
to
e57befd
Compare
|
@outscale-mgo your review has been checked and changes have been applied :) |
outscale-fne
force-pushed
the
fne-vhosts
branch
3 times, most recently
from
e62d406
to
fce41b9
Compare
outscale-toa
reviewed
Nov 9, 2020
outscale-toa
approved these changes
Nov 9, 2020
outscale-fne
force-pushed
the
fne-vhosts
branch
from
e774cac
to
ae855eb
Compare
outscale-fne
force-pushed
the
fne-vhosts
branch
from
ae855eb
to
9c2ff75
Compare
outscale-fne
commented
Nov 10, 2020
| @@ -278,7 +293,9 @@ static void vhost_create_socket(struct pg_vhost_state *state, uint64_t flags, | |||
| int ret; | |||
|
|
|||
| path = g_strdup_printf("%s/qemu-%s", sockets_path, state->brick.name); | |||
| g_remove(path); | |||
| /* If the socket is CLIENT do NOT destroy the socket. */ | |||
| if ((flags & 1) == 0) | |||
There was a problem hiding this comment.
Must set parenthesis @outscale-toa : Else I get this:
src/vhost.c: In function ‘vhost_create_socket’:
src/vhost.c:297:12: error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses]
if (flags & 1 == 0)
^
src/vhost.c: At top level:
cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ [-Werror]
cc1: error: unrecognized command line option ‘-Wno-unknown-warning-option’ [-Werror]
cc1: error: unrecognized command line option ‘-Wno-implicite-fallthrough’ [-Werror]
cc1: all warnings being treated as errors
Makefile:93: recipe for target 'src/vhost-dev.o' failed
make: *** [src/vhost-dev.o] Error 1
611a8ee
to
d7466f6
Compare
outscale-fne
force-pushed
the
fne-vhosts
branch
2 times, most recently
from
c047916
to
f0ff06d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to make QEMU act as a server and PACKETGRAPH as a client so they can handle both hotplugs.
This is using the virtio vhost protocol.