brick: ignore tap_burst error #531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-toa
force-pushed
the
ignore_error
branch
from
2241246
to
9b80273
Compare
outscale-mgo
requested changes
Mar 26, 2020
There was a problem hiding this comment.
also, thanks for the fix, but there is already a fix here:
#530
if you could approve it, I could merge it
src/brick.c
Outdated
| if (pg_error_is_set(errp)) | ||
| return; | ||
| if (pg_error_is_set(errp)) { | ||
| if (!strcmp((*errp)->context.file, "src/tap.c") && |
There was a problem hiding this comment.
I think you can ignore all error here, not only the one that would come from a tap
On some OS tap_brurt cannot write in /etc/net/tun file. What make impossible to unlink vtep with another brick. Signed-off-by: Thiery Ouattara <[email protected]>
outscale-toa
force-pushed
the
ignore_error
branch
from
9b80273
to
7ca221b
Compare
outscale-fne
approved these changes
Mar 30, 2020
outscale-mgo
requested changes
May 11, 2020
| if (pg_error_is_set(errp)) | ||
| return; |
There was a problem hiding this comment.
pg_error_free otherwise it would leak
| @@ -567,8 +567,11 @@ static void do_unlink(struct pg_brick *brick, enum pg_side side, uint16_t index, | |||
| return; | |||
|
|
|||
| unlink_notify(pair_edge, pg_flip_side(side), errp); | |||
|
|
|||
| /* TODO: This error come from tap_bust. But the goal here is to */ | |||
| /* unlink brick. We will find the best way to ignore this error soon */ | |||
There was a problem hiding this comment.
We will find the best way to ignore this error soon
...
yeah we all know that's a lie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some OS tap_brurt cannot write in /etc/net/tun file.
What make impossible to unlink vtep with another brick.
Signed-off-by: Thiery Ouattara [email protected]