vtep: add an option to have no multicast #528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Gatto <[email protected]>
outscale-toa
approved these changes
Mar 23, 2020
| @@ -388,6 +390,12 @@ static inline int vtep_encapsulate(struct vtep_state *state, | |||
| unicast = 0; | |||
| } | |||
|
|
|||
| if (state->flags & PG_VTEP_NO_MULTICAST && !unicast) { | |||
There was a problem hiding this comment.
I prefer if (!unicast && state->flags & PG_VTEP_NO_MULTICAST)
we don't have to do this state->flags & PG_VTEP_NO_MULTICAST operation if unicast==true
outscale-toa
requested changes
Mar 23, 2020
| @@ -795,7 +807,8 @@ static int do_add_vni(struct vtep_state *state, uint16_t edge_index, | |||
| *errp = pg_error_new("port already attached to a vni"); | |||
| return -1; | |||
| } | |||
| if (unlikely(pg_is_multicast_ip(port->multicast_ip))) { | |||
| if (!(state->flags & PG_VTEP_NO_MULTICAST) && | |||
| unlikely(pg_is_multicast_ip(port->multicast_ip))) { | |||
There was a problem hiding this comment.
Same here, i prefer unlikely(pg_is_multicast_ip(port->multicast_ip))first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: no merge now
Signed-off-by: Matthias Gatto [email protected]