Big Endian Support + NiDataStream Fixes#8
Draft
abso1utezer0 wants to merge 3 commits intoousnius:mainfrom
Draft
Conversation
ousnius
requested changes
Jan 13, 2026
Owner
ousnius
left a comment
ousnius
left a comment
There was a problem hiding this comment.
Thanks for the contribution. The tests seem to be passing.
Do you think you can add a new test for reading and writing a big endian file? Please don't include proprietary assets/meshes, though.
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
| buffer[1] = buffer[6]; | ||
| buffer[2] = buffer[5]; | ||
| buffer[3] = buffer[4]; | ||
| buffer[4] = buffer[3]; |
Owner
There was a problem hiding this comment.
This doesn't work for reversing values. Either use buffer.AsSpan(0, 8).Reverse(); or Array.Reverse or use temporary variables.
| return 1; | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
Remove unnecessary file edit NifFile.cs.
| using NiflySharp.Stream; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics; |
abso1utezer0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the old binary reader/writer with a custom implementation that supports switching between endianess on the fly.