Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect variable name #480

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ struct DelegatedTokenSetup {
library DelegatedTokenCreation {
/// @notice Decode and recover delegated token setup data from a signature. Works with multiple versions of
/// a signature. Takes an abi encoded premint config, version of the encoded premint config, and a signature,
/// decodes the config, and recoveres the signer of the config. Based on the premint config, builds
/// decodes the config, and recovers the signer of the config. Based on the premint config, builds
/// setup actions for the token to be created.
/// @param premintConfigEncoded The abi encoded premint config
/// @param premintVersion The version of the premint config
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {IERC1155Receiver} from "@openzeppelin/contracts/token/ERC1155/IERC1155Re
import {ContractVersionBase} from "../version/ContractVersionBase.sol";

/// @title Enables creation of and minting tokens on Zora1155 contracts transactions using eip-712 signatures.
/// Signature must provided by the contract creator, or an account that's permitted to create new tokens on the contract.
/// Signature must be provided by the contract creator, or an account that's permitted to create new tokens on the contract.
/// Mints the first x tokens to the executor of the transaction.
/// @author @oveddan
contract ZoraCreator1155PremintExecutorImpl is
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,15 @@ library ZoraCreator1155PremintExecutorImplLib {
bytes[] memory setupActions = toSetupActions(contractConfig.additionalAdmins);

// create the contract via the factory.
address newContractAddresss = zora1155Factory.createContractDeterministic(
address newContractAddress = zora1155Factory.createContractDeterministic(
contractConfig.contractURI,
contractConfig.contractName,
// default royalty config is empty, since we set it on a token level
ICreatorRoyaltiesControl.RoyaltyConfiguration({royaltyBPS: 0, royaltyRecipient: address(0), royaltyMintSchedule: 0}),
payable(contractConfig.contractAdmin),
setupActions
);
tokenContract = IZoraCreator1155(newContractAddresss);
tokenContract = IZoraCreator1155(newContractAddress);
}

function toSetupActions(address[] memory additionalAdmins) internal pure returns (bytes[] memory setupActions) {
Expand Down
4 changes: 2 additions & 2 deletions packages/1155-deployments/src/DeterministicDeployerScript.sol
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,9 @@ contract DeterministicDeployerScript is Script {
bytes32 proxyDeployerSalt = params.proxyDeployerSalt;
bytes memory proxyDeployerCreationCode = params.proxyDeployerCreationCode;

address createdAddresss = ImmutableCreate2FactoryUtils.safeCreate2OrGetExisting(proxyDeployerSalt, proxyDeployerCreationCode);
address createdAddress = ImmutableCreate2FactoryUtils.safeCreate2OrGetExisting(proxyDeployerSalt, proxyDeployerCreationCode);

if (createdAddresss != proxyDeployerAddress) revert("Mismatched address");
if (createdAddress != proxyDeployerAddress) revert("Mismatched address");

factoryDeployer = DeterministicProxyDeployer(proxyDeployerAddress);
}
Expand Down