Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Calendar): [BLA-694] add months and years views to calendar #500

Merged
merged 11 commits into from
Oct 15, 2024

Conversation

DushanNovak1983
Copy link
Contributor

@DushanNovak1983 DushanNovak1983 commented Oct 2, 2024

TODOs:

  • implement months view
  • implement years view
  • add storybook documentation
  • implement closing calendar on escape (on all views)
  • implement closing calendar on backdrop (on all views)
  • write unit tests
  • write e2e tests

REMARKS:

  • im not sure why some files are being re-formatted when building the code. I work with IntelliJ, do you maybe have some additional configuration on your mashines regarding eslint/prettier? This needs to be fixed or addressed in the documentation.
  • as already discussed with Vishwa, for some reason, some unit-tests are failing on my machine locally. But the reason is that when running npm run test the transpiled .js files from the dist folder are also being executed. What i did locally is running the tests with npx stencil test --spec --e2e -- src/components/. This needs to be fixed or addressed in the documentation.

@DushanNovak1983 DushanNovak1983 changed the title feat(Calendar): [BLA-694] add months view to calendar feat(Calendar): [BLA-694] add months and years views to calendar Oct 2, 2024
@vishwapriya vishwapriya reopened this Oct 15, 2024
@vishwapriya vishwapriya marked this pull request as ready for review October 15, 2024 07:15
@vishwapriya vishwapriya merged commit fbd12ef into otto-de:main Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants