Skip to content

Commit

Permalink
docs(developerGuidelines): [BLA-803] Update the docker command to run…
Browse files Browse the repository at this point in the history
… and update snapshots
  • Loading branch information
geethag-tw committed Jul 11, 2024
1 parent 4a9bce2 commit 7a402dc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ to 800px. The modal height is not limited. We recommend using the `large` varian
While the headline property is required and will always be shown in the modal, other parts of the modal such as the body and footer
content are optional.

Header has one slot - 'header-icon' that controls the icon to be displayed near the modal title.
Header has one slot - `header-icon` that controls the icon to be displayed near the modal title.

### Body Content

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ Once you have one of this two runtime envs, you can follow these steps:

1. Run `docker-compose up` or `docker-compose up --build` if you have created the services before. This creates a storybook service
and a service that runs the tests against storybook. If any test failed, you will find a new folder inside `__snapshots__` called `__diff_output__`.
2. If the differences were expected (because you made visual changes to an existing component), run `docker-compose run run-tests npx test-storybook --verbose --url http://storybook:6006 -u`
2. If the differences were expected (because you made visual changes to an existing component), run `docker-compose run run-tests npx test-storybook --verbose --url http://storybook.local:6006 -u`


#### Making changes to the docker image
Expand Down
2 changes: 1 addition & 1 deletion test.Docker.README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ This rebuilds the storybook and test-runner services to include recent changes a
If there is a new component, simply rebuilding starting the services is enough as the normal entrypoint automatically adds new screenshots.
However, if you made intended visual changes to an existing component, you will need to run:

`docker-compose run run-tests npx test-storybook --verbose --url http://storybook:6006 -u`
`docker-compose run run-tests npx test-storybook --verbose --url http://storybook.local:6006 -u`

to override the default command and update the snapshots.

0 comments on commit 7a402dc

Please sign in to comment.