Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): update contributing and pr template #46

Merged
merged 6 commits into from
Jul 17, 2023

Conversation

BirgitBader
Copy link
Contributor

With #45 many broken links have been fixed.
This has general effects on how we link to rules in changelog entries.
Furthermore, keeping the context in the changelog, when rules have been deleted, makes it necessary to state the rule name.

Copy link
Contributor

@cgebken cgebken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me. Should we add an example with a rule in the example of the contributing.md to make the usage even more clear and better to understand?

@BirgitBader
Copy link
Contributor Author

BirgitBader commented Jul 17, 2023

Fine for me. Should we add an example with a rule in the example of the contributing.md to make the usage even more clear and better to understand?

@cgebken Added in 5f55645

@BirgitBader BirgitBader merged commit ab14d3e into main Jul 17, 2023
1 check passed
@BirgitBader BirgitBader deleted the update-contributing branch July 17, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants