Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminology: Rename annotation intents.otterize.com/service-name to intents.otterize.com/workload-name, retaining support for backward compatibility #542

Merged
merged 3 commits into from
Jan 19, 2025

Conversation

omris94
Copy link
Contributor

@omris94 omris94 commented Jan 8, 2025

Description

Aligning terminology following v2 API version on which Intent.Spec.Service was renamed to Intent.Spec.Workload

References

#439

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

…ame` to `intents.otterize.com/workload-name`
@omris94 omris94 requested a review from amitlicht January 8, 2025 14:38
@omris94 omris94 changed the title Update terminology: Rename annotation intents.otterize.com/service-name to intents.otterize.com/workload-name, retaining support for backward compatibility. Update terminology: Rename annotation intents.otterize.com/service-name to intents.otterize.com/workload-name, retaining support for backward compatibility Jan 8, 2025
@omris94 omris94 merged commit c30c1b1 into main Jan 19, 2025
20 checks passed
@omris94 omris94 deleted the omris/change-service-label branch January 19, 2025 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants