Rename spec.service to spec.workload in KafkaServerConfig API version v2alpha1
#540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omris94
changed the title
spec.service to spec.workload in KafkaServerConfig api version v2alpha1spec.service to spec.workload in KafkaServerConfig api version v2alpha1
omris94
changed the title
spec.service to spec.workload in KafkaServerConfig api version v2alpha1spec.service to spec.workload in KafkaServerConfig API version v2alpha1
orishoshan
reviewed
Jan 2, 2025
src/shared/serviceidresolver/serviceidentity/serviceidentity.go
Outdated
Show resolved
Hide resolved
| @@ -821,7 +821,7 @@ func (s *CloudReconcilerTestSuite) TestReportKindAndAlias() { | |||
| cloudIntent, err := intent.ConvertToCloudFormat(context.Background(), s.client, serviceidentity.ServiceIdentity{Name: clientName, Namespace: testNamespace, Kind: "StatefulSet"}) | |||
| s.Require().NoError(err) | |||
| s.Require().Equal(lo.FromPtr(cloudIntent.ServerWorkloadKind), "Deployment") | |||
| s.Require().Equal(lo.FromPtr(cloudIntent.ServerAlias), graphqlclient.ServerAliasInput{Name: lo.ToPtr(serverName + "." + testNamespace), Kind: lo.ToPtr("Service")}) | |||
| s.Require().Equal(lo.FromPtr(cloudIntent.ServerAlias), graphqlclient.ServerAliasInput{Name: lo.ToPtr(serverName + "." + testNamespace), Kind: lo.ToPtr("Workload")}) | |||
src/operator/controllers/intents_reconcilers/cloud_reconciler_test.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aligning KSC with clientIntents by using the same terminology
Testing
Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).
Checklist