Fixed webhook cert ns (#63)

* fix webhook name * Fixing webhook namespace in certificate. Fixed tests that used old tests API but passed PR gate
otterize · Oct 11, 2022 · 0dc9de6 · 0dc9de6
1 parent 94ec6d6
commit 0dc9de6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/operator/controllers/intents_reconcilers/external_network_poilicy_test.go b/src/operator/controllers/intents_reconcilers/external_network_poilicy_test.go
@@ -72,10 +72,12 @@ func (s *ExternalNetworkPolicyReconcilerTestSuite) BeforeTest(_, testName string
 
 func (s *ExternalNetworkPolicyReconcilerTestSuite) TestNetworkPolicyCreateForIngress() {
 	serviceName := "test-server-ingress-test"
-	intents := s.AddIntents("test-intents", "test-client", []otterizev1alpha1.Intent{{
+	intents, err := s.AddIntents("test-intents", "test-client", []otterizev1alpha1.Intent{{
 		Type: otterizev1alpha1.IntentTypeHTTP, Name: serviceName,
 	},
 	})
+	s.Require().NoError(err)
+
 	s.Require().True(s.Mgr.GetCache().WaitForCacheSync(context.Background()))
 
 	res, err := s.NetworkPolicyReconciler.Reconcile(context.Background(), ctrl.Request{
@@ -126,10 +128,11 @@ func (s *ExternalNetworkPolicyReconcilerTestSuite) TestNetworkPolicyCreateForIng
 
 func (s *ExternalNetworkPolicyReconcilerTestSuite) TestNetworkPolicyCreateForLoadBalancer() {
 	serviceName := "test-server-load-balancer-test"
-	intents := s.AddIntents("test-intents", "test-client", []otterizev1alpha1.Intent{{
+	intents, err := s.AddIntents("test-intents", "test-client", []otterizev1alpha1.Intent{{
 		Type: otterizev1alpha1.IntentTypeHTTP, Name: serviceName,
 	},
 	})
+	s.Require().NoError(err)
 	s.Require().True(s.Mgr.GetCache().WaitForCacheSync(context.Background()))
 
 	res, err := s.NetworkPolicyReconciler.Reconcile(context.Background(), ctrl.Request{
@@ -183,10 +186,11 @@ func (s *ExternalNetworkPolicyReconcilerTestSuite) TestNetworkPolicyCreateForLoa
 
 func (s *ExternalNetworkPolicyReconcilerTestSuite) TestNetworkPolicyCreateForNodePort() {
 	serviceName := "test-server-node-port-test"
-	intents := s.AddIntents("test-intents", "test-client", []otterizev1alpha1.Intent{{
+	intents, err := s.AddIntents("test-intents", "test-client", []otterizev1alpha1.Intent{{
 		Type: otterizev1alpha1.IntentTypeHTTP, Name: serviceName,
 	},
 	})
+	s.Require().NoError(err)
 	s.Require().True(s.Mgr.GetCache().WaitForCacheSync(context.Background()))
 
 	res, err := s.NetworkPolicyReconciler.Reconcile(context.Background(), ctrl.Request{

diff --git a/src/operator/main.go b/src/operator/main.go
@@ -166,7 +166,7 @@ func main() {
 	if selfSignedCert == true {
 		logrus.Infoln("Creating self signing certs")
 		certBundle, err =
-			webhooks.GenerateSelfSignedCertificate("intents-operator-webhook-service", "intents-operator-system")
+			webhooks.GenerateSelfSignedCertificate("intents-operator-webhook-service", podNamespace)
 		if err != nil {
 			logrus.WithError(err).Fatal("unable to create self signed certs for webhook")
 		}