fix string_view issue in ProtocolGame::parseRuleViolationReport #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturKnopik
commented
Nov 23, 2024
| @@ -1419,7 +1419,7 @@ void ProtocolGame::parseRuleViolationReport(NetworkMessage& msg) | |||
| uint8_t reportReason = msg.getByte(); | |||
| auto targetName = msg.getString(); | |||
| auto comment = msg.getString(); | |||
| std::string_view translation; | |||
| std::string translation; | |||
| if (reportType == REPORT_TYPE_NAME) { | |||
| translation = msg.getString(); | |||
There was a problem hiding this comment.
msg.getString() returns temporary string object.
ramon-bernardo
approved these changes
Nov 23, 2024
EPuncker
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed:
Fix temporary string to string_view assignment in ProtocolGame::parseRuleViolationReport