Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add a new method to check if Thing has a parent (#4810)" #4835

Closed
wants to merge 1 commit into from

Conversation

MillhioreBT
Copy link
Contributor

@MillhioreBT MillhioreBT commented Nov 16, 2024

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

This causes the containers or cylinders in general to stop working and causes a crash.
It would be better if @ramon-bernardo solves it, if not, it is simply better to revert it

2024-11-16.17-47-28.mp4

Issues addressed: Nothing!

@MillhioreBT MillhioreBT added bug An issue describing unexpected behavior of code priority: critical Issues with this label should be resolved as quickly as possible labels Nov 16, 2024
@ramon-bernardo
Copy link
Contributor

Fixed #4828

@ramon-bernardo ramon-bernardo mentioned this pull request Nov 16, 2024
3 tasks
@EPuncker EPuncker closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected behavior of code priority: critical Issues with this label should be resolved as quickly as possible
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants