Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of depot chest #4794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Sep 25, 2024

Pull Request Prelude

Changes Proposed

  • Enhanced handling of DepotChest: Improved the identification and access to the DepotChest class through the getDepotChest method.

  • Default pagination disabled: The default setting for pagination in the DepotChest has been modified to be disabled.

Usage

// Create a DepotChest instance
if (auto depot_chest = new DepotChest(ITEM_DEPOT)) {
    // Adding items to the depot
    depot_chest->queryAdd(0, Item::CreateItem(ITEM_MARKET), 1);

    // Cleanup
    delete depot_chest;
}

// Get depot id
auto container = { ... }
if (auto depotLocker = container->getDepotLocker()) {
    auto id = depotLocker->getDepotId();
} else if (auto depotChest = container->getDepotChest()) {
    auto id = depotChest->getDepotId();
}

@EPuncker EPuncker requested review from nekiro, ranisalt, DSpeichert, EvilHero90 and MillhioreBT and removed request for nekiro September 25, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant