Use Party shared_ptr instead of raw pointers #4687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekiro
reviewed
May 16, 2024
- checking now if param 2 is not a number, incase that's true we tell that the player does not exist - added another check which actually looks if the player is valid before comparing any names
…land#4686) * Replace deprecated asio functions * Bump minimal Boost version
* added request resource balance * pr comments
* Update workflow actions, trigger builds on workflow update * Fix artifact naming
* doubling the vartrack size Increasing the max-vartrack-size because luascript.cpp has a function which exceeded the limit and thus the build failed
This reverts commit 98c55fa.
* Refactor Docker image workflow with docker actions
* Create cpplinter.lua
* Don't install libiconv outside OSX, install Lua by default
Codinablack
reviewed
May 26, 2024
| @@ -564,8 +563,7 @@ ChatChannel* Chat::getChannel(const Player& player, uint16_t channelId) | |||
| } | |||
|
|
|||
| case CHANNEL_PARTY: { | |||
| Party* party = player.getParty(); | |||
| if (party) { | |||
| if (const auto& party = player.getParty()) { | |||
There was a problem hiding this comment.
It's been my experience that declaring a variable and checking it at same time inside the if statement causes crashes. I'm sure this isn't true in all cases, but I'm just stating what has been my experience so far.
There was a problem hiding this comment.
How so? It's equivalent other than the scoping (which would cause compilation errors, not crashes)
Would be interesting to see a form of reproduction though
There was a problem hiding this comment.
I have an example you can use to reproduce. I will contact you about it on discord.
* Use Guild shared_ptr * Member rank level default to constexpr * Use const when possible * @ramon-bernardo Use const when possible * Use shared_ptr alias * Fix * Fix * Fix * Fix * Fix delete * Fix * No need to reuse the variable * Use const shared ptr * Use const& ptr * Inline rank check
* Split game core into different files * eof
* Fix some warnings and improve type annotations * Fix `item:transform` type annotation * Remove `dump` function from compat.lua * Fix `configKeys` type annotations * Refactor all enums/constants of `cpplinter.lua` and fix ident style to tabs Some were missing and others were wrong, I got them all directly from the source. * Refactor the PlayerFlag constants in cpplinter.lua to use bitwise shift operators instead of exponentiation
* Moved everything to NpcScriptInterface There was an issue with the Revisioned Npc System. Because it was included in 2 different lua environments it would not correctly work on any of the cmake builds only the msvc builds worked fine (they somehow have shared lua envs) Now the npcs should correctly work as it's expected
Moved all std::vector out of the pointer class itself and put them into their singleton classes (Actions/MoveEvents) They're now stored in a std::map map by their pointer as a std::vector and once it is registered it clears the std::map with the pointer index.
- checking first if the pointer has a map (is valid) before trying to get it's content
this sets NULL default for session tokens, just for safety
Add monster icons correctly when creature appears on the screen
- Added `onSight` event, this has to be enabled with `NpcType:sight(x, y)` unless that is not set the event wont fire. This event triggers whenever a creature (monsters/npcs/players) steps into the sight range, will only re trigger once you walk out of idle range and back in again. - fixed event callbacks, they're now moved into `NpcCallbacks` they can be set like: `NpcType:callbacks().onSay/onSight/etc.` - fixed a crash which could occur if you had a npc disabled then enabled him and /reload npcs, this is now fixed - fixed a crash that if a xml npc is invalid on server startup that it throws an error instead of crashing - made all the functions in the lib overloadable, only the table data is protected, you can now change functions and they will be correctly changed on /reload npcs - changed everything related to focus from seconds into ms - changed focus so it works for all creatures not only players - changed NpcTalkQueue it now works for creatures not only for players - changed the onCreatureSay event, it now triggers for all creatures not only for players - selfSay has a new parameter now called talkType which is optional and falls back to TALKTYPE_SAY - added `onSpeechBubble` event, with this we can set the speech bubble for each player individual. example: Npc has a quest for the player he only shows for this player the quest speech bubble, once the quest is finished the npc wont have a quest speech bubble anymore --------- Co-authored-by: Evil Puncker <[email protected]> Co-authored-by: KrecikOnDexin <[email protected]>
* Remove Account class and account.h file * Update theforgottenserver.vcxproj
Co-authored-by: Xmish <[email protected]>
Set the correct chance for ice mammoth sculpting. * Use stats from tibia-stats research (bigger sample size)
was constant 650, now it's 65–350
…forgottenserver into shared_ptr-party
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
autoandconst auto, at all, when possible.