container/encapsulate: Support copying commit metadata keys #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
label-commit-meta
branch
2 times, most recently
from
d074754
to
459c659
Compare
For coreos/coreos-assembler#2685 we want to copy e.g. `rpmostree.input-hash` into the container image. Extend the `ExportOpts` struct to support this, and also expose it via the CLI, e.g. `ostree container encapsulate --copymeta=rpmostree.input-hash ...`. And while I was thinking about this...we should by default copy some core ostree keys, such as `ostree.bootable` and `ostree.linux` since they are key pieces of metadata.
cgwalters
force-pushed
the
label-commit-meta
branch
from
459c659
to
4eb9203
Compare
|
OK yeah, there's some bug in |
jlebon
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For coreos/coreos-assembler#2685
we want to copy e.g.
rpmostree.input-hashinto the container image.Extend the
ExportOptsstruct to support this, and also exposeit via the CLI, e.g.
ostree container encapsulate --copymeta=rpmostree.input-hash ....And while I was thinking about this...we should by default copy
some core ostree keys, such as
ostree.bootableandostree.linuxsince they are key pieces of metadata.