AI: WebRTC: Support optional msid attribute per RFC 8830. v7.0.126 (#4570) #4572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #4570 by supporting optional
msidattribute in WebRTC SDP negotiation, enabling compatibility with libdatachannel and other clients that don't include msid information.SRS failed to negotiate WebRTC connections from libdatachannel clients because:
a=ssrc:XX msid:stream_id track_idattributesIf diligently look at the SDP generated by libdatachannel:
It's deliberately missing the
a=ssrc:XX msid:stream_id track_idline, comparing that with this one:In such a situation, to keep compatible with libdatachannel, if no msid line in sdp, SRS comprehensively and consistently uses: