WebRTC: Fix NACK recovered packets not being added to receive queue. v7.0.78 #4467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winlinvip
changed the title
winlinvip
added
the
AI Handled
winlinvip
changed the title
winlinvip
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in WebRTC NACK packet recovery mechanism where recovered packets were being discarded instead of processed.
In
SrsRtcRecvTrack::on_nack(), when a retransmitted packet arrived (found in NACK receiver), the method would:This caused recovered packets to be lost, defeating the purpose of the NACK mechanism and potentially causing media quality issues.
Restructured the control flow in
on_nack()to ensure both new and recovered packets reach the packet insertion logic:Closes #3820
Co-authored-by: Haibo Chen [email protected]