Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lexicon.yaml with control mappings #179

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Conversation

SecurityCRob
Copy link
Contributor

add control mapping references

add control mapping references

Signed-off-by: CRob <[email protected]>
Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall, just a couple of questions before I ✅

synonyms:
- SSDF
- NIST Secure Software Development Framework
- NIST SP 800-218
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add "SP 800-218" as a synonym?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to chat more about how we're taking advantage of synonyms— right not they are not being rendered

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #182 for that conversation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixing meow

baseline/lexicon.yaml Outdated Show resolved Hide resolved
@funnelfiasco
Copy link
Contributor

YAML error, too:

2025/02/04 16:35:18 Error reading YAML file: error reading lexicon: error decoding YAML: yaml: line 10: did not find expected '-' indicator

SecurityCRob and others added 4 commits February 4, 2025 12:40
Co-authored-by: Eddie Knight <[email protected]>
Signed-off-by: CRob <[email protected]>
tweaked ssdf

Signed-off-by: CRob <[email protected]>
now with 100% MOAR SBOM!

Signed-off-by: CRob <[email protected]>
Signed-off-by: Ben Cotton <[email protected]>
@funnelfiasco
Copy link
Contributor

YAML error, too:

I pushed commit ea5808b which fixes this. (The problem was leading spaces before - term in a couple of places)

Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor comments (we can fix them in another PR)

baseline/lexicon.yaml Outdated Show resolved Hide resolved
baseline/lexicon.yaml Outdated Show resolved Hide resolved
Co-authored-by: Puerco <[email protected]>
Signed-off-by: Eddie Knight <[email protected]>
@eddie-knight eddie-knight merged commit 77e8c8b into main Feb 6, 2025
2 checks passed
@eddie-knight eddie-knight deleted the SecurityCRob-patch-13 branch February 6, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants