Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggested implementation for DO-13 #153

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

evankanderson
Copy link
Contributor

I think we discussed this a bit during the call.

It also appears that the OpenEoX work may not be very stable; I've asked a clarifying question here: oasis-tcs/openeox#64

I also have not looked at how common the different methods are based on guidance from https://endoflife.date/, but that seems like a logical next step.

Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a weak preference for softening the language a bit to make the methods listed be examples instead of "you must choose from this set" (which may not be the intent, but it's one possible reading). Overall, though, I'm fine with this as-is.

@evankanderson
Copy link
Contributor Author

I'm happy to expand the set -- my real goal was to spark discussion about how to do this.

Looking more at endoflife.date, it appears that they have markdown front-matter to collect this information, and then collect this information into JSON files based on the front-matter and sometimes on additional scripts.

While this isn't everything, standardizing on something like:

auto:
  methods:
  -   git: https://github.com/istio/istio.git
  -   release_table: https://istio.io/latest/docs/releases/supported-releases/
      selector: "table"
      fields:
        releaseCycle: "Version"
        eol:
          column: "End of Life"
          regex: '^~?(?P<value>\w+ \d+(, \d+)?).*'
        supportedKubernetesVersions:
          column: "Supported Kubernetes Versions"
          type: "range"

would probably be a nice step forward.

Copy link
Contributor

@SecurityCRob SecurityCRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SecurityCRob SecurityCRob merged commit 8dfef53 into ossf:main Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants