-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom Banner #254
Added custom Banner #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening your first pull request 😊 ! We really appreciate your work. Happy Coding 🎉🎊 !
Hi @ParthAdhana , I am so happy for your contribution. We will review it together and merge asap 😊💯 |
Hi @FanJups , Thanks for the kind word , please let me know if any corrections are to be made in this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal here is to use the name of the module, in this case jsgenerator-api, jsgenerator-cli, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turning these names into ascii art with this website https://patorjk.com/software/taag/#p=display&f=Big&t=JSGENERATOR-API
https://patorjk.com/software/taag/#p=display&f=Big&t=JSGENERATOR-CLI
https://www.baeldung.com/spring-boot-custom-banners @ParthAdhana thanks again for your contribution. You got the idea but there are some changes to do. What is the purpose of .history folder ? First, just add this property into application.yaml of slim api and slim cli spring:
banner:
location: classpath:/banner.txt Then, create src/main/resources/banner.txt in these 2 modules. Go to https://patorjk.com/software/taag/#p=display&f=Big&t=JSGENERATOR-API to get the content for api and https://patorjk.com/software/taag/#p=display&f=Big&t=JSGENERATOR-CLI for cli modules. Copy and paste the result into banner.txt of each module. How to know if everything work well ? Please, make sure you are using Maven 4 then just run these commands for api Note: Next time, don't use the main branch for PR, it is not a good practice. Instead, create another feature branch on your fork and use that one. This link will give you more details |
@ParthAdhana any issues ? I am here to help. |
This PR addresses "Using Spring Boot Custom Banners #252" issue .
The custom Banner is present in Banner.txt file along with application.yaml file
Closes #252