Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom Banner #254

Closed
wants to merge 0 commits into from
Closed

Added custom Banner #254

wants to merge 0 commits into from

Conversation

ParthAdhana
Copy link
Contributor

@ParthAdhana ParthAdhana commented Aug 14, 2023

This PR addresses "Using Spring Boot Custom Banners #252" issue .
The custom Banner is present in Banner.txt file along with application.yaml file

Closes #252

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening your first pull request 😊 ! We really appreciate your work. Happy Coding 🎉🎊 !

@FanJups
Copy link
Member

FanJups commented Aug 14, 2023

Hi @ParthAdhana , I am so happy for your contribution. We will review it together and merge asap 😊💯

@ParthAdhana
Copy link
Contributor Author

Hi @FanJups , Thanks for the kind word , please let me know if any corrections are to be made in this PR :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal here is to use the name of the module, in this case jsgenerator-api, jsgenerator-cli, ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FanJups
Copy link
Member

FanJups commented Aug 15, 2023

Hi @FanJups , Thanks for the kind word , please let me know if any corrections are to be made in this PR :)

https://www.baeldung.com/spring-boot-custom-banners

@ParthAdhana thanks again for your contribution. You got the idea but there are some changes to do. What is the purpose of .history folder ?

First, just add this property into application.yaml of slim api and slim cli

spring:
  banner:
    location: classpath:/banner.txt

Then, create src/main/resources/banner.txt in these 2 modules.

Go to https://patorjk.com/software/taag/#p=display&f=Big&t=JSGENERATOR-API to get the content for api and https://patorjk.com/software/taag/#p=display&f=Big&t=JSGENERATOR-CLI for cli modules.

Copy and paste the result into banner.txt of each module.

How to know if everything work well ?

Please, make sure you are using Maven 4 then just run these commands for api spring-boot:run --projects jsgenerator-api and cli spring-boot:run --projects jsgenerator-cli at the root directory js-generator. Then, just pay attention to console output.

Note: Next time, don't use the main branch for PR, it is not a good practice. Instead, create another feature branch on your fork and use that one. This link will give you more details

https://stackoverflow.com/questions/48434973/should-i-create-a-branch-of-the-fork-while-creating-pr-for-apache-kafka#:~:text=Whenever%20you%20begin%20work%20on,for%20every%20task%20you%20complete.

@FanJups
Copy link
Member

FanJups commented Aug 16, 2023

@ParthAdhana any issues ? I am here to help.

@ParthAdhana
Copy link
Contributor Author

@FanJups I have created another PR and this time from a feature branch can you please check that one out, #256 I am not sure if that is the correct way of doing that , as it is still my first PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Spring Boot Custom Banners
2 participants