Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph button fix #711

Merged
merged 1 commit into from
May 27, 2024
Merged

graph button fix #711

merged 1 commit into from
May 27, 2024

Conversation

cdolfi
Copy link
Collaborator

@cdolfi cdolfi commented May 9, 2024

On smaller screens the prior implementation would have the button and input on different lines, closes #670

@cdolfi cdolfi requested a review from JamesKunstle May 9, 2024 21:12
JamesKunstle
JamesKunstle approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@JamesKunstle JamesKunstle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a styling change to I don't see a reason not to merge it if it looks good to you.

px is preferred for width as opposed to rm or em.

@JamesKunstle JamesKunstle merged commit 02beda3 into oss-aspen:dev May 27, 2024
5 checks passed
@cdolfi cdolfi deleted the response_info_button branch October 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesKunstle JamesKunstle JamesKunstle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Aspen Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix "about graph" button location on response graphs
2 participants
@cdolfi @JamesKunstle