-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages #631
Update packages #631
Conversation
I've unpinned all the versions to catch everything up, but I'm going to repin them after this PR. I'm going to try to use pipenv but if that still sucks I'll check out Poetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes and needs to be brought up to date. Once that is done and an issue is created for repinning itll be good to merge!
8Knot/pages/contributions/visualizations/cntrb_pr_assignment.py
Outdated
Show resolved
Hide resolved
8Knot/pages/contributions/visualizations/cntrib_issue_assignment.py
Outdated
Show resolved
Hide resolved
19e2ced
to
507da9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small TODO before merge:
- squash commits
- open issue for re pinning
- remove comments if not applicable
then will be good to go
8Knot/pages/contributors/visualizations/contrib_importance_pie.py
Outdated
Show resolved
Hide resolved
|
@JamesKunstle Sweet, can you bring the branch back up to date and ill merge! Not too sure how it got out of date but since it is package stuff i want to make sure we are thorough |
@cdolfi should be up to date |
@JamesKunstle Sorry should have done the merge in the opposite order. Could you bring it up to date and squash any unnecessary commits? |
98e6d1f
to
d789b4e
Compare
caught all requirements up to date by unpinning dependencies and letting pip resolve related dependencies. this required some changes to using the Pandas API because of some breaking inter-version changes. Signed-off-by: James Kunstle <[email protected]>
Signed-off-by: James Kunstle <[email protected]>
Signed-off-by: James Kunstle <[email protected]>
Signed-off-by: James Kunstle <[email protected]>
d789b4e
to
779d6df
Compare
@cdolfi squashed commits, rebased onto current dev, should be good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and ran on fresh build
had to make small pandas API changes since we're updating like 6 versions.