Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages #631

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Update packages #631

merged 4 commits into from
Feb 13, 2024

Conversation

JamesKunstle
Copy link
Contributor

had to make small pandas API changes since we're updating like 6 versions.

@JamesKunstle
Copy link
Contributor Author

I've unpinned all the versions to catch everything up, but I'm going to repin them after this PR. I'm going to try to use pipenv but if that still sucks I'll check out Poetry

@cdolfi cdolfi self-requested a review January 31, 2024 20:51
Copy link
Collaborator

@cdolfi cdolfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes and needs to be brought up to date. Once that is done and an issue is created for repinning itll be good to merge!

Copy link
Collaborator

@cdolfi cdolfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small TODO before merge:

  • squash commits
  • open issue for re pinning
  • remove comments if not applicable

then will be good to go

@JamesKunstle
Copy link
Contributor Author

JamesKunstle commented Feb 6, 2024

@cdolfi

  1. re-pinned dependencies using modern Python app dependency management best-practice
  2. removed comments you noted, ty for finding those
  3. I think the commits I made are discrete changes and shouldn't be squashed.

@cdolfi
Copy link
Collaborator

cdolfi commented Feb 6, 2024

@JamesKunstle Sweet, can you bring the branch back up to date and ill merge! Not too sure how it got out of date but since it is package stuff i want to make sure we are thorough

@JamesKunstle
Copy link
Contributor Author

@cdolfi should be up to date

@cdolfi
Copy link
Collaborator

cdolfi commented Feb 12, 2024

@JamesKunstle Sorry should have done the merge in the opposite order. Could you bring it up to date and squash any unnecessary commits?

@JamesKunstle JamesKunstle force-pushed the update_packages branch 2 times, most recently from 98e6d1f to d789b4e Compare February 13, 2024 17:54
caught all requirements up to date by unpinning dependencies and letting
pip resolve related dependencies. this required some changes to using
the Pandas API because of some breaking inter-version changes.

Signed-off-by: James Kunstle <[email protected]>
Signed-off-by: James Kunstle <[email protected]>
@JamesKunstle
Copy link
Contributor Author

JamesKunstle commented Feb 13, 2024

@cdolfi squashed commits, rebased onto current dev, should be good to go

Copy link
Collaborator

@cdolfi cdolfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and ran on fresh build

@cdolfi cdolfi merged commit 3af11ce into oss-aspen:dev Feb 13, 2024
5 checks passed
@cdolfi cdolfi mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint 33
Development

Successfully merging this pull request may close these issues.

2 participants