Welcome page instructions #380
Conversation
|
Easy visualization of changes: Tab 1: Tab 2: Tab 3: |
|
Making this PR now ahead of writing more code- it's lots of HTML and CSS so smaller PRs is more polite. Going to add two more tabs, one for Augur groups and one for Augur collection requests. Also want to make tabs more visible- the bootstrap styling keeps overriding my styling attempts and I'm trying to avoid using '!imporant' if possible. |
There was a problem hiding this comment.
Overall I think the design of this is awesome, super big fan of the set up. Most of my review comments is about getting the wording more concise. The other major thing to note that I did not know where to put is to inform users about triggering collection on repositories not in the db by adding them to an user group
| @@ -11,25 +11,25 @@ h3 { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
(doesnt need to be in this pr, if not lets open an issue): lets make a styling folder and image folder in assets
There was a problem hiding this comment.
Maybe a folder for all the assets for the welcome page (two folders youve made in), just spitballing
There was a problem hiding this comment.
Yeah that's reasonable. I know that Dash does some styling document auto-discovery for *.css files in the /assets folder, so moving all of the styling into a subfolder might make it invisible to the app. That being said, I can't imagine that that wouldn't be configurable.
There was a problem hiding this comment.
That makes sense, def would open as a different issue then
| html.Div( | ||
| className="card_section_description", | ||
| children=[ | ||
| html.H1("8Knot Pages"), |
There was a problem hiding this comment.
The alignment of this section feels a little off. I see that every other box has the left alignment on top but this one might work better as a middle alignment. If not, I would move the pages to be stacked if you are trying to keep all styling the exact same throughout
There was a problem hiding this comment.
Yeah I wanted your eye on that- I looked at it too long to have an opinion anymore.
Some sites do what I did, others center the element; some do text-align center, others do text-align left... I'm going to just pick something that looks *okay* and go with it.
pages/welcome/welcome.py
Outdated
| children=[ | ||
| html.Img(src="assets/logo-color.png"), | ||
| html.P( | ||
| """ | ||
| Open source communities are difficult to understand. 8Knot serves community stakeholders by |
There was a problem hiding this comment.
Not sure how I feel about the first sentence. Could see taking it out or changing it to something like "Open source communities are complex and full of nuance." Also trying to think of a different word for "stakeholders", to me it gives a corporatey vibe
There was a problem hiding this comment.
++ very fair. This has felt like a placeholder for a while since we haven't done any marketing-copy stuff. I'll make it more concise but we should loop back purposefully.
Thank you for reviewing so quickly- this is PR number 1 of 2, so you don't have a huge PR to review at once. In the second I'm going to add instructions for creating user groups from the catalog, and for requesting collection using their user groups. In this PR I want to nail down the wording and design of the first three tabs, which you already commented on in your review, before continuing on 👍 |
JamesKunstle
force-pushed
the
extend-welcome-instructions
branch
2 times, most recently
from
a434e2c
to
4b735ab
Compare
|
New pages: General: Plotly: Augur: |
|
@cdolfi |
|
@JamesKunstle What is BI? Besides that everything looks good to me. Curious to hear @bproffitt thoughts on the wording as well |
Ah, that's "Business Intelligence". The BI shorthand is common enough (tools like PowerBI exist, for instance) that I used it here. I thought maybe "Community Managers" would be preferred over "Community Architects"? idk, I'll chat Brian about it. |
JamesKunstle
force-pushed
the
extend-welcome-instructions
branch
from
4b735ab
to
618e9ee
Compare
|
@cdolfi made changed requested by @bproffitt |
|
@JamesKunstle only comment I have is to change "BI" to full say "Business Intelligence." BI might be common vernacular in certain circles but atleast I have never heard it before. And it stays consistent for full title as developers and community architect are |
continues work on oss-aspen#353 Adds instructions to Welcome page, restyles in more minimalistic color palette. Design is inspired by some layouts from https://www.sigstore.dev/community Tabs added: 'General' 'Plotly Figure Tools' 'Your Augur Account' Signed-off-by: James Kunstle <[email protected]>
JamesKunstle
force-pushed
the
extend-welcome-instructions
branch
from
618e9ee
to
651ca6f
Compare
|
@cdolfi made the BI => "Business Intelligence" change. |
continues work on #353
Adds instructions to Welcome page, restyles in
more minimalistic color palette.
Design is inspired by some layouts from
https://www.sigstore.dev/community
Tabs added:
'General'
'Plotly Figure Tools'
'Your Augur Account'