Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-rebuild images after package sync (or rebuild images nightly) #784

Open
rursprung opened this issue Jan 4, 2025 · 3 comments
Open

Comments

@rursprung
Copy link

right now (2025-01-05) the current images (as listed on docker hub) are from 2024-12-03, however on 2024-12-31 a new for jazzy has been done.

it'd be great if the tooling could somehow be automated to automatically build a new image after every sync.
as an alternative - which might be even better - the images could just be rebuilt e.g. daily. rebuilding the images often is one of the docker best practices and would also help in reducing the reported amount of vulnerabilities on the docker images on docker hub (since these vulnerabilities come from dependencies which tend to be fixed in the mean time).

whatever rebuild policy is being chosen: it'd be great if the README would clearly state when the images get rebuilt.

@rursprung rursprung changed the title auto-rebuild images after package sync auto-rebuild images after package sync (or rebuild images nightly) Jan 4, 2025
@mikaelarguedas
Copy link
Contributor

Thanks for reporting, this is the goal (lots more details on 112)

This is currently blocked by docker-library/official-images#17960

Each image will contain the rosdistro sync date in the environment and a new image will be built with that updated env var at each sync,

Hope this helps,

@rursprung
Copy link
Author

thanks! but i think #112 is only half the story here since the dockerfiles still need to be updated?
e.g. right now it still refers to an older sync date:

ENV ROSDISTRO_PKGS_SYNC_DATE=2024-11-21

@mikaelarguedas
Copy link
Contributor

the dockerfiles still need to be updated?

This is a requirement from the official docker images processs: the only way to trigger a rebuild is to modify the dockerfiles and then submit the new dockerfiles by making a PR to their repo with the new commit hash

right now it still refers to an older sync date:

Yes, that PR introduces the element we need in the dockerfile to then be able to automate the file modification and the PR submission on their repo. We need first that PR to be merged for follow-up PRs to be created
That's what I meant by the fact that this is currently blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants