-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hillshading and contour lines #78
Conversation
Thanks @jake-low, this looks amazing! The terrain really brings the map together. It will definitely take some cartography work to get the look we want. The terrain is useful but we don't want information overload to impact readability, especially on the analysis views. The protected areas were intentionally opaque since otherwise overlapping translucent areas create unintentionally stacked fills. (There is an open issue at MapLibre for setting the transparency of an entire layer, which would fix the situation.) Can you move the terrain folder to https://github.com/osmus/tileservice? That repo is for all our tile work, not just stuff that runs on our render server. The terrain tiles will be useful for various maps, not just OTM. Also, you can push these types of branches to OSM US repos directly instead of forks if you want. Makes things a bit easier. |
This looks fantastic! Woohoo, @jake-low!
Maybe it would work to flip the order? Make the hillshade layer the semi-transparent one and put it above the opaque park fill layer? |
Thanks!
This is a good idea, I'll give that a try. It'll have the unwanted effect of muting the colors of the park areas (and anything else we move underneath the hillshade) but I can compensate for that by increasing the saturation of those layers. Maybe someday MapLibre will support blend modes like multiply, that would be really handy for hillshade layers. |
Take 2: this time the I haven't pulled the |
@jake-low This looks really really good. I'd say the styling is ready to merge as soon as we have the full tile sets posted. (We don't have to get it exact, we're constantly tweaking the carto.) |
The hillshade effect provides a pretty strong "fill" effect at these low zooms, and showing state/province boundaries was creating too much visual noise (especially in countries with many small subdivisions).
Hillshade and contour tilesets are finished building for the planet. I also made some tweaks to the styling, namely:
Terrain tileset building scripts have been removed from this PR and moved over to osmus/tileservice instead. See osmus/tileservice#18
|
Thank you @jake-low! I'm super excited for this. |
This PR includes some scripts to generate hillshade and contour line tilesets from Mapzen's global DEM data. I've run these scripts on my machine to produce tilesets that cover Washington State, and put those in the S3 bucket where the existing tiles are served from.
I also added the hillshade and contours to the basemap stylesheet, and made minor tweaks to the
park-fill
andpark-outline
style layers (park-fill
was fully opaque; I made it semi-transparent so you can see the hillshades and contours underneath). Other parts of the stylesheet may need tweaking too, and the changes I made were very quick and dirty, and could certainly be finetuned more.You can try it out for yourself by pulling down this branch, running
npm run serve
, and then panning to somewhere in Washington.Some things I'd like feedback on:
Once you're happy with the look of the results I can work on spinning up a server in AWS to crank out tiles for the whole world. I think it'll require minor modifications to the scripts (
mercantile
doesn't support enumerating tiles for an irregularly shaped region, so I'll write some custom code to avoid wasting a bunch of compute on tiling the oceans). Shouldn't be too hard though.Before:
After:
Closes #51