Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: whitelisted txfees receiving module addresses #8847

Closed
wants to merge 3 commits into from

Conversation

crnbarr93
Copy link
Contributor

@crnbarr93 crnbarr93 commented Nov 26, 2024

What is the purpose of the change

During epoch the following info log appears:

10:42AM INF The following non-native tokens were not swapped (see debug logs for further details): [17289527factory/osmo17fel472lgzs87ekt9dvk0zqyh5gl80sqp4sk4n/LAB via pool 1642 48586factory/osmo1dv8wz09tckslr2wy5z86r46dxvegylhpt97r9yd6qc3kyc6tv42qa89dr9/ampOSMO via pool 1461 287430factory/osmo1s3l0lcqc7tu0vpj6wdjz9wqpxv8nk6eraevje4fuwkyjnwuy82qsx3lduv/boneOsmo via pool 1643 3350000000000gamm/pool/10 via pool 101 13695769356ibc/0E4FA664327BD40B32803EE84A77F145834C0281B7F82B65521333B3669FA0BA via pool 974 7061231010ibc/447A0DCE83691056289503DDAB8EB08E52E167A73629F2ACC59F056B92F51CE8 via pool 962 1145516399ibc/64D56DF9EC69BE554F49EBCE0199611062FF1137EF105E2F645C1997344F3834 via pool 1584 54612151900ibc/987C17B11ABC2B20019178ACE62929FE9840202CE79498E29FE8E5CB02B7C0A4 via pool 1635 1434760659870ibc/98BCD43F190C6960D0005BC46BB765C827403A361C9C03C2FF694150A30284B0 via pool 1575 123992804ibc/C25A2303FE24B922DAFFDCE377AC5A42E5EF746806D32E2ED4B610DE85C203F7 via pool 1572 645417872ibc/DEA3B0BB0006C69E75D2247E8DC57878758790556487067F67748FDC237CE2AE via pool 996 45229325448ibc/EDD6F0D66BCD49C1084FB2C35353B4ACD7B9191117CE63671B61320548F7C89D via pool 1463] module=serve

Debugging this and printing the error causing this info log shows the following:

3:23PM ERR Error swapping non-native fee to denom error="dispatch: submessages: dispatch: submessages: osmo1g7ajkk295vactngp74shkfrprvjrdwn662dg26 is not allowed to receive funds: unauthorized" module=server

This is due to the receiving module addresses being blocked by the bank module. These changes add the following three modules to the slice of module addresses that are allowed to receive funds:

  • NonNativeTxFeeCollectorName
  • TakerFeeCommunityPoolName
  • TakerFeeStakersName

NOTE: This does not completely solve the issue but removes a small amount of them and exposes underlying issues.

Testing and Verifying

Tested with an in-place-testnet with frequent epochs and a debugger.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@crnbarr93 crnbarr93 added the V:state/breaking State machine breaking PR label Nov 26, 2024
@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Nov 26, 2024
@crnbarr93 crnbarr93 changed the title fix: whitelisted protorev receiving module addresses fix: whitelisted txfees receiving module addresses Nov 26, 2024
@crnbarr93 crnbarr93 closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant