Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow dispatch condition to dev docker build #8846

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

pablin-10
Copy link
Contributor

@pablin-10 pablin-10 commented Nov 26, 2024

What is the purpose of the change

Allow to have a preview docker build manually from arbitrary tags when needed

@pablin-10 pablin-10 requested a review from a team as a code owner November 26, 2024 14:29
@github-actions github-actions bot added the T:CI label Nov 26, 2024
Copy link
Contributor

@alessandrolomanto alessandrolomanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niccoloraspa
Copy link
Member

niccoloraspa commented Nov 26, 2024

i think you need to add inputs, otherwise it would not work right?
Or maybe not 🤔

This shouldn't fail:

GITHUB_TAG=${{ github.ref_name }}

Could you test this on a fork to make sure?

@niccoloraspa
Copy link
Member

utACK

@pablin-10 pablin-10 merged commit d652dfb into main Nov 26, 2024
1 check passed
@pablin-10 pablin-10 deleted the allow_manual_dev_docker_build branch November 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants