admin warm --reverse-only should not run search queries #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonvia
reviewed
Sep 28, 2023
| for _ in range(1000): | ||
| api.reverse((random.uniform(-90, 90), random.uniform(-180, 180)), | ||
| address_details=True) | ||
|
|
||
| if args.target != 'search': | ||
| if args.target == 'search': |
There was a problem hiding this comment.
It's more complicated. If args.target is not set at all this must be run as well.
Also, I think your comment was right that we simply should skip warming search on a reverse-only DB.
|
Did a slightly different fix with f1fbcd8 which also includes handling of reverse-only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nominatim admin warm --reverse-onlyshould not run (forward) search queries.fixes #3213