Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shields for Brazil #425

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Add shields for Brazil #425

wants to merge 14 commits into from

Conversation

claysmalley
Copy link
Member

@claysmalley claysmalley commented Jun 16, 2022

Tradução automática em português abaixo

(EN)

Adds support for shields of Brazil.

Tagging of network=* in Brazil is hierarchical. BR represents federal highways, and state highways have BR: followed by two-letter state codes. Federal highways have a unique black-on-white shield, and state highways have a black-on-white pentagonal shield with similar dimensions to the standard US county shield. These two-letter codes are generally present on shields, though not always in line with the route number.

In their current state, ref=* values can't be used for this project. Tagging in Brazil includes these two-letter prefixes, redundant to network=*. We would need to preprocess these values to remove the prefix (#141). However, this is probably a problem better solved by changing the tagging to remove the prefixes from ref=*.


(PT)

Adiciona suporte para placas de rodovia do Brasil.

A marcação de network=* no Brasil é hierárquica. BR representa rodovias federais e rodovias estaduais têm BR: seguido por códigos estaduais de duas letras. As rodovias federais têm uma placa de rodovia preto sobre branco exclusivo, e as rodovias estaduais têm uma placa pentagonal preto sobre branco com dimensões semelhantes à placa padrão do condado dos EUA. Esses códigos de duas letras geralmente estão presentes nas placas, embora nem sempre estejam alinhados com o número da rota.

Em seu estado atual, os valores ref=* não podem ser usados para este projeto. A marcação no Brasil inclui esses prefixos de duas letras, redundantes para network=*. Precisaríamos pré-processar esses valores para remover o prefixo (#141). No entanto, este é provavelmente um problema melhor resolvido alterando a marcação para remover os prefixos de ref=*.

Screenshot from 2022-06-15 20-53-54

BR-020 SP-065

@claysmalley claysmalley mentioned this pull request Jun 18, 2022
@1ec5
Copy link
Member

1ec5 commented Jun 21, 2022

In their current state, ref=* values can't be used for this project. Tagging in Brazil includes these two-letter prefixes, redundant to network=*. We would need to preprocess these values to remove the prefix (#141). However, this is probably a problem better solved by changing the tagging to remove the prefixes from ref=*.

We’ll need to reach out to the Brazilian mapping community about making this change, perhaps through the mailing list, forum, or Telegram.

@claysmalley
Copy link
Member Author

I think the best place for international communication is probably the forum. I'll write up a post there, and if any other communication channels are more active, we can announce it in those places as well.

@claysmalley
Copy link
Member Author

Shield icons removed in favor of draw functions.

Federal highway shield replaced with home plate shape. Both this and the previous design seem to be common in Brazil, but the home plate is easier for us to fit text in.

Screenshot from 2023-01-16 13-41-14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants