Add latin text highway shields for Japan #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
approved these changes
May 7, 2022
There was a problem hiding this comment.
As in #219 (comment), I agree that we should move forward with these uncontroversial networks and resolve the urban expressways separately.
| @@ -0,0 +1,3 @@ | |||
| <svg width="20" height="20" viewBox="0 0 5.292 5.292" xmlns="http://www.w3.org/2000/svg"> | |||
| <path d="m0.60707 0.13229c-0.26207 0-0.47478 0.21271-0.47478 0.47478v2.0388c0 1.3875 1.1261 2.5135 2.5135 2.5135 1.3875 0 2.5135-1.1261 2.5135-2.5135v-2.0388c0-0.26207-0.2127-0.47478-0.47478-0.47478h-2.0388z" fill="#006747" stroke="#fff" stroke-linejoin="round" stroke-width=".265"/> | |||
There was a problem hiding this comment.
This SVG is unused for now. Let’s leave it for #219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of #219 which provides comprehensive shield rendering for Japan highways. Support is added for those highway shields which are consistent with international norms and prefixed with the JP country code. This allows us to add the shield to the map that we all agree should be rendered, while deferring the routes with more controversial network values.