Fix Again KP_X Issue
#1542
Merged
Fix Again KP_X Issue
#1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f83d28c.
Those keys are already handled in `CommonKeyboardActionListener`, so ignoring those keys here. Removing the related codes in `CommonKeyboardActionListener` will make `KP_X` keys not working in normal text field.
WhiredPlanck
approved these changes
Jan 2, 2025
| sendDownKeyEvent(eventTime, keyCode, it.modifiers.metaState) | ||
|
|
||
| if (keyCode in KeyEvent.KEYCODE_NUMPAD_0..KeyEvent.KEYCODE_NUMPAD_EQUALS) { | ||
| // ignore KP_X keys, which is handled in `CommonKeyboardActionListener`. |
There was a problem hiding this comment.
This may cause IMS cannot reponse the corresponding keyevent from physical keyboard, maybe we should tell if the keyevent is from virtual keyboard or physical keyboard. But now, let us workaround for virtual keyboard first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes #1524
Feature
My bad. Previous fix in f83d28c will cause
KP_Xkeys not working in normal text field.This fix will let
KP_Xworking correctly in normal & number text field.Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info