Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 20241226 #1540

Merged
merged 9 commits into from
Dec 29, 2024
Merged

Refactor 20241226 #1540

merged 9 commits into from
Dec 29, 2024

Conversation

WhiredPlanck
Copy link
Collaborator

@WhiredPlanck WhiredPlanck commented Dec 26, 2024 •
edited
Loading

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes # N/A

Feature

Describe features of this pull request

This PR is an effort to improve may things as follow before 2025 new year:

  1. Merge RimeNotification and RimeEvent as RimeMessage to unify the massages pulled by rime backend.
  2. Slightly improve the preedit view display.
  3. Make the user experience of the deploy process more friendly, users will receive a notification that guide them to view error logs on deploy failure, otherwise a success toast will be shown.
  4. Improve candidate item and schema switch display, if the text of a candidate item is too long, it will be automatically scaled.
  5. Improve candidate window display, fix incorrect positioning and abnormal item layout.
  6. Remove speech recognition, because it mostly cannot work well with the less of network permissions. Although some ROMs like MIUI or HyperOS can make it work without the permissions, most users don't benefit from it anymore.
  7. Other cleanups to the code trees.

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck
feat: improve candidate item display
e605620 
- Make the long text can be automatically scaled, powered by the adapted AutoScaleTextView from fcitx5-android [1]
- Once a candidate item contains a non-empty comment, all the text will align to baseline
- Clean up the code tree of CandidateItemUi

Ref:
1. https://github.com/fcitx5-android/fcitx5-android/blob/3dff0a3a94c68cc3e8030b62ef548570b5a0c434/app/src/main/java/org/fcitx/fcitx5/android/input/AutoScaleTextView.kt
@WhiredPlanck
feat: improve switch display
43b6b82 
- Improve the display just like do with candidate
- Cleanup the code tree of SwitchUi
@WhiredPlanck
feat: improve candidate window display
eb30f78
@WhiredPlanck WhiredPlanck marked this pull request as ready for review December 29, 2024 08:45
@WhiredPlanck WhiredPlanck requested review from goofyz and Bambooin and removed request for goofyz December 29, 2024 08:46
@WhiredPlanck
refactor: remove speech recognition
ff49060 
A fine-working speech recognition requires network permission, which against our privacy policy. Although some ROMs like MIUI / HyperOS may make it work without network permission, most users don't benefit from it.
@WhiredPlanck
refactor: deprecate IMS instance getter
04786db
@WhiredPlanck WhiredPlanck merged commit 0be5946 into osfans:develop Dec 29, 2024
3 checks passed
@WhiredPlanck WhiredPlanck deleted the refactor-20241226 branch December 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bambooin Bambooin Bambooin approved these changes

@goofyz goofyz Awaiting requested review from goofyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhiredPlanck @Bambooin