Reduced memory consumption

[nerg4l]

Reusing the file resource reduces the memory usage by almost 40%.

Peak memory usage:

• 19573984 bytes without change, triggered GC twice.
• 12002672 bytes with change, triggered GC twice.
• 13291832 bytes with Guzzle client, triggered GC zero times.

[nerg4l]

Time:

• 01:03.780 without change, triggered GC twice.
• 00:42.684 with change, triggered GC twice.
• 00:08.776 with Guzzle client, triggered GC zero times.

This shows quite big difference between \Embed\Http\CurlClient and Guzzle client. Maybe it would make sense to add a getClientFactory and only fall back to CurlClient when it is necessary.

Also, I couldn't figure out what happens with the curl_multi_* commands because $connection->result is ignored and $connection->exec is called anyway. It looks like exec is called twice for each connection, once curl_multi_exec and later curl_exec, am I correct?

Embed/src/Http/CurlDispatcher.php

Lines 57 to 64 in 530593a

	if ($info) {
	foreach ($connections as $connection) {
	if ($connection->curl === $info['handle']) {
	$connection->result = $info['result'];
	break;
	}
	}
	}

[oscarotero]

Thanks!
About $connection->exec, probably this is the reason of the bug.
It's called here: https://github.com/oscarotero/Embed/blob/master/src/Http/CurlDispatcher.php#L80 to construct the response, but the function also run curl_exec https://github.com/oscarotero/Embed/blob/master/src/Http/CurlDispatcher.php#L118

[oscarotero]

I just made this change 51b1aea
Can you test the memory usage?